Skip to content

fix(ci): The setup-node action freezes on Windows #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
megahertz merged 2 commits into from
May 1, 2025
+3 −2
Merged

fix(ci): The setup-node action freezes on Windows #466

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d569cd2
chore: Try skip nodeinstall on win32
megahertz May 1, 2025
637e1a0
chore: Simplify conditions
megahertz May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
electron_version: latest
experimental: true
- os: windows-latest
node_version: latest
node_version: builtin # For an unknown reason, setup-node freezes
electron_version: latest
experimental: true

Expand All @@ -59,14 +59,15 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node_version }}
if: matrix.node_version != 'builtin'

- run: npm config set script-shell 'bash'
if: runner.os == 'Windows'

- run: npm install

- run: npm install -D electron@${{ matrix.electron_version }}
if: ${{ matrix.electron_version != 'latest' }}
if: matrix.electron_version != 'latest'

- run: |
if [ "${RUNNER_OS}" = 'Linux' ]; then
Expand Down