Oblique illumination reconstructions#501
Draft
talonchandler wants to merge 13 commits into
Draft
Conversation
Collaborator
Author
|
The tests are passing, but this isn't quite ready for review + merge until after the 3.0.0 release. Oblique reconstructions require CZYX arrays (instead of the current ZYX arrays), which means introducing a backwards incompatible change to the API. Let's review and merge this after 3.0.0. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
+ Coverage 46.59% 46.71% +0.12%
==========================================
Files 51 51
Lines 10460 10531 +71
==========================================
+ Hits 4874 4920 +46
- Misses 5586 5611 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds multi-aperture oblique illumination reconstructions to
waveorder.A single new parameter
illumination_sector_anglesenables these reconstructions, best described by example:illumination_sector_angles = Noneuses the old behavior---a single circular illumination apertureillumination_sector_angles = [(0, 45), (45, 90)]reconstructs from two sector-illumination channels, the first sector from 0-45 degrees and the second from 45-90 degrees.illumination_sector_angles = [(i * sector_angle, (i + 1) * sector_angle) for i in range(8)] + [(0, 360)]reconstructs from 8 sector-illumination channels and a final full-aperture channel.Below is a simulation of a sphere (first column) and simulated data acquired under different illumination orientation (second column). As expected, the reconstruction with a single full aperture (third column) is not as sharp as the reconstruction with all 9 channels (last column).
2025-10-24-multiaperture.mov