Skip to content

Oblique illumination reconstructions#501

Draft
talonchandler wants to merge 13 commits into
mainfrom
oblique-illumination
Draft

Oblique illumination reconstructions#501
talonchandler wants to merge 13 commits into
mainfrom
oblique-illumination

Conversation

@talonchandler

@talonchandler talonchandler commented Oct 24, 2025

Copy link
Copy Markdown
Collaborator

This PR adds multi-aperture oblique illumination reconstructions to waveorder.

A single new parameter illumination_sector_angles enables these reconstructions, best described by example:

  1. illumination_sector_angles = None uses the old behavior---a single circular illumination aperture
  2. illumination_sector_angles = [(0, 45), (45, 90)] reconstructs from two sector-illumination channels, the first sector from 0-45 degrees and the second from 45-90 degrees.
  3. illumination_sector_angles = [(i * sector_angle, (i + 1) * sector_angle) for i in range(8)] + [(0, 360)] reconstructs from 8 sector-illumination channels and a final full-aperture channel.

Below is a simulation of a sphere (first column) and simulated data acquired under different illumination orientation (second column). As expected, the reconstruction with a single full aperture (third column) is not as sharp as the reconstruction with all 9 channels (last column).

2025-10-24-multiaperture.mov

@talonchandler

Copy link
Copy Markdown
Collaborator Author

The tests are passing, but this isn't quite ready for review + merge until after the 3.0.0 release.

Oblique reconstructions require CZYX arrays (instead of the current ZYX arrays), which means introducing a backwards incompatible change to the API. Let's review and merge this after 3.0.0.

@codecov

codecov Bot commented Jan 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.04124% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.71%. Comparing base (5384c90) to head (bb84315).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
waveorder/cli/settings.py 50.00% 15 Missing ⚠️
waveorder/models/isotropic_thin_3d.py 75.00% 6 Missing ⚠️
waveorder/optics.py 45.45% 6 Missing ⚠️
waveorder/models/phase_thick_3d.py 86.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
+ Coverage   46.59%   46.71%   +0.12%     
==========================================
  Files          51       51              
  Lines       10460    10531      +71     
==========================================
+ Hits         4874     4920      +46     
- Misses       5586     5611      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant