Rename Datastar attributes from _ds prefix to _data prefix#18
Merged
andymeierdev merged 4 commits intomainfrom Feb 28, 2026
Merged
Rename Datastar attributes from _ds prefix to _data prefix#18andymeierdev merged 4 commits intomainfrom
andymeierdev merged 4 commits intomainfrom
Conversation
The _ds shorthand was unclear. Renamed all Datastar attributes to use the _data prefix (e.g., _dsShow -> _dataShow, _dsBind -> _dataBind) for better consistency with the underlying data-* HTML attributes. Removed the generic _ds helper from Datastar since Html._data already provides the same functionality. https://claude.ai/code/session_019s59KCRtbdgh6H3YMXfTxj
Adds test coverage for all renamed Datastar attributes, verifying they render the correct data-* HTML attributes. Also adds `open type Datastar` to the test module imports. https://claude.ai/code/session_019s59KCRtbdgh6H3YMXfTxj
F# triple-quoted strings cannot end with a `"` character before the closing `"""`, as the parser greedily matches the first `"""` it finds. Switched to regular escaped strings for assertions containing quoted attribute values. https://claude.ai/code/session_019s59KCRtbdgh6H3YMXfTxj
🍹
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _ds shorthand was unclear. Renamed all Datastar attributes to use
the _data prefix (e.g., _dsShow -> _dataShow, _dsBind -> _dataBind)
for better consistency with the underlying data-* HTML attributes.
Removed the generic _ds helper from Datastar since Html._data already
provides the same functionality.
https://claude.ai/code/session_019s59KCRtbdgh6H3YMXfTxj