Skip to content

Add Datastar object-syntax overloads and expand test coverage#19

Merged
andymeierdev merged 2 commits intomainfrom
ameier/datastar-overloads-and-tests
Feb 28, 2026
Merged

Add Datastar object-syntax overloads and expand test coverage#19
andymeierdev merged 2 commits intomainfrom
ameier/datastar-overloads-and-tests

Conversation

@andymeierdev
Copy link
Copy Markdown
Collaborator

@andymeierdev andymeierdev commented Feb 28, 2026

Changes

Datastar object-syntax overloads

Added single-string overloads for attributes that support object syntax per the Datastar docs:

  • _dataAttr(v)data-attr="{...}"
  • _dataClass(v)data-class="{...}"
  • _dataComputed(v)data-computed="{...}"
  • _dataSignals(v)data-signals="{...}"
  • _dataStyle(v)data-style="{...}"

Test coverage expansion

Split monolithic Tests.fs into separate files by area:

  • CoreTests.fs (20 tests) — rendering, void/regular elements, encoding, builders, boolean attrs, iteration, pool, DOCTYPE
  • DatastarTests.fs (3 tests) — keyed attrs, object-syntax overloads, remaining attrs
  • HtmxTests.fs (1 test) — all 14 htmx attributes
  • AlpineTests.fs (1 test) — all Alpine attributes with overload variants
  • SvgTests.fs (1 test) — all SVG elements and attributes
  • TailwindTests.fs (2 tests) — all custom elements, _popover, _anchor

All 27 tests pass across net8.0, net9.0, and net10.0.

Deploy workflow

Changed deploy.yml trigger from push-to-main to release published or manual dispatch.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 28, 2026

🍹 preview on fsharp-view-engine/prod

Pulumi report

View in Pulumi Cloud

  Previewing update (prod)

View Live: https://app.pulumi.com/meiermade/fsharp-view-engine/prod/previews/2a9d40f7-227a-4f0c-9292-476ade651ef0

pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:prod::fsharp-view-engine::pulumi:pulumi:Stack::fsharp-view-engine-prod]
  ~ docker-build:index:Image: (update)
      [id=sha256:7dce1dac725cac480a57d3912a6d0747a6e506fead31a37c5d0e1cf2750b1959]
      [urn=urn:pulumi:prod::fsharp-view-engine::docker-build:index:Image::fsharpviewengine]
    - contextHash: "32c3cf094b28e25b8e71394d2f292a85a12bc075e03d3953ab1235a7d3f2b43b"
  ~ kubernetes:apps/v1:Deployment: (update)
      [id=fsharpviewengine/fsharpviewengine]
      [urn=urn:pulumi:prod::fsharp-view-engine::kubernetes:apps/v1:Deployment::fsharpviewengine]
    ~ spec: {
        ~ template: {
            ~ spec: {
                ~ containers: [
                    ~ [0]: {
                            ~ image: "941377122014.dkr.ecr.us-east-1.amazonaws.com/fsharpviewengine:latest@sha256:d70ad44878f59aa5da6ae62822906d7f90b9cdce620439d61cf89ca503deffeb" => [unknown]
                          }
                  ]
              }
          }
      }
Resources:
  ~ 2 to update
  10 unchanged
  

@andymeierdev andymeierdev merged commit 6600872 into main Feb 28, 2026
2 checks passed
@andymeierdev andymeierdev deleted the ameier/datastar-overloads-and-tests branch February 28, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant