Skip to content

fix(sound): improve volume handling and validation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lavrov08 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sound): improve volume handling and validation #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions components/ambient-sounds.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,15 @@ export function AmbientSounds({ onActivityMessage }: AmbientSoundsProps) {
// Update volume for all audio elements when volume changes
useEffect(() => {
Object.entries(audioRefs.current).forEach(([soundId, audio]) => {
if (!audio) return

const sound = sounds.find((s) => s.id === soundId)
if (sound) {
audio.volume = (volume / 100) * sound.volumeMultiplier
if (sound && sound.volumeMultiplier !== undefined && !isNaN(sound.volumeMultiplier)) {
const calculatedVolume = Math.max(0, Math.min(1, (volume / 100) * sound.volumeMultiplier))
audio.volume = calculatedVolume
}
})
}, [volume])
}, [volume, audioRefs.current])

const toggleSound = async (soundId: string) => {
const audio = audioRefs.current[soundId]
Expand All @@ -106,7 +109,12 @@ export function AmbientSounds({ onActivityMessage }: AmbientSoundsProps) {
// Start new sound
try {
// Apply normalized volume before playing
audio.volume = (volume / 100) * sound.volumeMultiplier
if (sound.volumeMultiplier !== undefined && !isNaN(sound.volumeMultiplier)) {
const calculatedVolume = Math.max(0, Math.min(1, (volume / 100) * sound.volumeMultiplier))
audio.volume = calculatedVolume
} else {
audio.volume = Math.max(0, Math.min(1, volume / 100))
}
await audio.play()
setActiveSound(soundId)
onActivityMessage(`Someone's vibing to ${sound.name} ${sound.icon}`, "sound")
Expand Down Expand Up @@ -178,7 +186,7 @@ export function AmbientSounds({ onActivityMessage }: AmbientSoundsProps) {
</div>
<Slider
value={[volume]}
onValueChange={(value) => setVolume(value[0])}
onValueChange={(value: number[]) => setVolume(value[0])}
max={100}
step={1}
className="w-full"
Expand Down