Fix emperor_dilemma: resolve relative imports and update SpaceRenderer API#338
Open
mehaksalil wants to merge 3 commits intomesa:mainfrom
Open
Fix emperor_dilemma: resolve relative imports and update SpaceRenderer API#338mehaksalil wants to merge 3 commits intomesa:mainfrom
mehaksalil wants to merge 3 commits intomesa:mainfrom
Conversation
Author
|
The absolute imports are required for Solara to run the example locally |
Contributor
|
I really can't understand the motive of this PR.
Tests are failing |
mehaksalil
force-pushed
the
fix-emperor-dilemma
branch
from
7bc3899 to
7be96d9
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337
The emperor_dilemma example was broken and could not be run due to two issues:
Relative imports across app.py, model.py, and agents.py were incompatible
with how Solara loads example modules. Changed to absolute imports.
SpaceRenderer.setup_agents() no longer exists in the current Mesa API.
Updated to use the current .render(agent_portrayal=...) pattern,
consistent with other examples like rumormill.
Applied ruff formatting fixes.
The example now runs correctly.