Skip to content

fix(acl): persist guest last_timestamp across reboot #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swaits wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(acl): persist guest last_timestamp across reboot #2533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/helpers/ClientACL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ void ClientACL::save(FILESYSTEM* fs, bool (*filter)(ClientInfo*)) {

for (int i = 0; i < num_clients; i++) {
auto c = &clients[i];
if (c->permissions == 0 || (filter && !filter(c))) continue; // skip deleted entries, or by filter function
// Persist guest entries (permissions == 0) so their last_timestamp survives
// reboot — otherwise a captured guest packet can be replayed once after
// power cycle. The explicit-delete path in applyPermissions() removes the
// slot entirely, so any permissions==0 entry here is a real (guest) client.
if (filter && !filter(c)) continue;

bool success = (file.write(c->id.pub_key, 32) == 32);
success = success && (file.write((uint8_t *) &c->permissions, 1) == 1);
Expand Down