Skip to content

Update CLI command parameters for bridge source#2534

Open
khagele wants to merge 1 commit into
meshcore-dev:mainfrom
khagele:patch-1
Open

Update CLI command parameters for bridge source#2534
khagele wants to merge 1 commit into
meshcore-dev:mainfrom
khagele:patch-1

Conversation

@khagele
Copy link
Copy Markdown

@khagele khagele commented May 12, 2026

No description provided.

@StijnBTC
Copy link
Copy Markdown

StijnBTC commented May 12, 2026

The change is correct, the set command already accepts rx/tx (not logRx/logTx).

Adding to this, the get/query command still returns the old names:

src/helpers/CommonCLI.cpp:832

sprintf(reply, "> %s", _prefs->bridge_pkt_src ? "logRx" : "logTx");

This should be changed to:

sprintf(reply, "> %s", _prefs->bridge_pkt_src ? "rx" : "tx");

Without this fix, a user running get bridge.source will see logTx while the docs say tx.

Optionally, these comments could also be updated for consistency:

  • src/helpers/CommonCLI.h:48// 0 = logTx, 1 = logRx (default logTx)
  • examples/simple_repeater/MyMesh.cpp:894// logTx

But logRx and logTx are used in lots of other parts of the code so maybe it would make more sense to change it to accept both tx/rx and logTx/logRx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants