Skip to content

Proposal: Introduce shutdownPeripherals in NRF52Board to prepare for shutdown #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fdlamotte wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −3
Open

Proposal: Introduce shutdownPeripherals in NRF52Board to prepare for shutdown #2906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/helpers/NRF52Board.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ float NRF52Board::getMCUTemperature() {
return temp * 0.25f; // Convert to *C
}

void NRF52Board::powerOff() {
void NRF52Board::shutdownPeripherals() {
// Power off the display if any
#ifdef DISPLAY_CLASS
display.turnOff();
Expand All @@ -318,6 +318,10 @@ void NRF52Board::powerOff() {
// Flush serial buffers
Serial.flush();
delay(100);
}

void NRF52Board::powerOff() {
shutdownPeripherals();

// Enter SYSTEMOFF
uint8_t sd_enabled = 0;
Expand Down
1 change: 1 addition & 0 deletions src/helpers/NRF52Board.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class NRF52Board : public mesh::MainBoard {
virtual uint8_t getStartupReason() const override { return startup_reason; }
virtual float getMCUTemperature() override;
virtual void reboot() override { NVIC_SystemReset(); }
virtual void shutdownPeripherals();
virtual void powerOff() override;
virtual bool getBootloaderVersion(char* version, size_t max_len) override;
virtual bool startOTAUpdate(const char *id, char reply[]) override;
Expand Down
4 changes: 2 additions & 2 deletions variants/lilygo_techo/TechoBoard.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ class TechoBoard : public NRF52BoardDCDC {
return "LilyGo T-Echo";
}

void powerOff() override {
NRF52Board::powerOff();
void shutdownPeripherals() override {
NRF52Board::shutdownPeripherals();
#ifdef LED_RED
digitalWrite(LED_RED, HIGH);
#endif
Expand Down
Loading