feat: add error handling framework

Cargo.toml

@@ -1,7 +1,11 @@
 [package]
 name = "hit-cli"
-version = "0.5.0"
+version = "0.5.1"
 edition = "2021"
+authors = ["Mehmood S. Deshmukh <meshde.md@gmail.com>"]
+homepage = "https://usehit.dev"
+repository = "https://github.com/meshde/hit-cli"
+license-file = "LICENSE"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
@@ -20,6 +24,7 @@ edit = "0.1.5"
 flatten-json-object = "0.6.1"
 getopts = "0.2.21"
 handlebars = "5.1.2"
+human-panic = "2.0.2"
 hyper = "1.3.1"
 inquire = "0.7.5"
 openapiv3 = "1.0.1"

src/cli/mod.rs

@@ -6,6 +6,7 @@ mod run;
 
 use crate::core::command::Command as ConfigCommand;
 use crate::core::config::{CommandType as ConfigCommandType, Config};
+use crate::utils::error::CliError;
 use clap::{command, Arg, ArgMatches, Command, FromArgMatches as _, Parser, Subcommand};
 use clap_complete::CompleteEnv;
 use convert_case::{Case, Casing};
@@ -129,6 +130,11 @@ pub async fn init() -> ExitCode {
     };
 
     if let Err(_e) = output {
+        if let Some(e) = _e.downcast_ref::<CliError>() {
+            eprintln!("{}", e);
+        } else {
+            panic!("{}", _e);
+        }
         ExitCode::FAILURE
     } else {
         ExitCode::SUCCESS

src/cli/run.rs

@@ -3,6 +3,7 @@ use crate::core::command::Command;
 use crate::core::config::Config;
 use crate::core::env::get_env;
 use crate::core::ephenv::get_ephenvs;
+use crate::utils::error::CliError;
 use crate::utils::http::handle_request;
 use colored_json;
 use edit::edit;
@@ -31,8 +32,24 @@ pub async fn run(
 
     let url = api_call.url.as_str();
 
-    let current_env = get_env().expect("env not set");
-    let env_data = config.envs.get(&current_env).expect("env not recognized");
+    let current_env = match get_env() {
+        Some(e) => e,
+        None => {
+            return Err(Box::new(CliError {
+                message: "env not set".to_string(),
+                help: None,
+            }))
+        }
+    };
+    let env_data = match config.envs.get(&current_env) {
+        Some(d) => d,
+        None => {
+            return Err(Box::new(CliError {
+                message: "env not recognized".to_string(),
+                help: None,
+            }))
+        }
+    };
     let ephenv_data = get_ephenvs();
     let merged_data = env_data
         .clone()
@@ -76,7 +93,8 @@ pub async fn run(
             .collect::<HashMap<String, String>>(),
         input,
     )
-    .await?;
+    .await
+    .unwrap();
 
     get_app_config().set_prev_request(response.clone());
 

src/main.rs

@@ -3,11 +3,14 @@ mod constants;
 mod core;
 mod utils;
 
-use reqwest;
+use human_panic;
+use std::process;
 use tokio;
 
 #[tokio::main]
-async fn main() -> Result<(), reqwest::Error> {
-    cli::init().await;
-    Ok(())
+async fn main() -> process::ExitCode {
+    human_panic::setup_panic!(human_panic::Metadata::new("hit", env!("CARGO_PKG_VERSION"))
+        .authors("Mehmood S. Deshmukh <meshde.md@gmail.com>")
+        .homepage("https://github.com/meshde/hit-cli/issues"));
+    cli::init().await
 }

src/utils/error.rs

@@ -0,0 +1,15 @@
+use std::error::Error;
+use std::fmt;
+
+#[derive(Debug)]
+pub struct CliError {
+    pub message: String,
+    pub help: Option<String>,
+}
+
+impl fmt::Display for CliError {
+    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+        write!(f, "{}", self.message)
+    }
+}
+impl Error for CliError {}

src/utils/mod.rs

@@ -1,2 +1,3 @@
+pub mod error;
 pub mod http;
 pub mod input;

tests/fixtures/mod.rs

@@ -27,7 +27,12 @@ impl SetupFixture {
                     "API_URL": "https://staging-api.example.com"
                 }
             },
-            "commands": {}
+            "commands": {
+                "get-by-id": {
+                    "method": "GET",
+                    "url": "{{API_URL}}/items/:id",
+                }
+            }
         });
 
         fs::write(&config_path, test_config.to_string()).unwrap();

tests/run_tests.rs

@@ -0,0 +1,26 @@
+mod fixtures;
+use assert_cmd::prelude::*;
+use fixtures::{get_hit_command_for_setup, hit_setup, SetupFixture};
+use rstest::*;
+
+#[rstest]
+fn test_failure_when_env_not_set(
+    hit_setup: SetupFixture,
+) -> Result<(), Box<dyn std::error::Error>> {
+    let mut cmd = get_hit_command_for_setup(&hit_setup);
+    cmd.args(["run", "get-by-id", "--id", "meshde"]);
+    cmd.assert().failure().stderr("env not set\n");
+
+    Ok(())
+}
+
+#[rstest]
+fn test_failure_when_env_not_recognized(hit_setup: SetupFixture) -> () {
+    let mut use_cmd = get_hit_command_for_setup(&hit_setup);
+    use_cmd.args(["env", "use", "something"]);
+    use_cmd.assert().success();
+
+    let mut cmd = get_hit_command_for_setup(&hit_setup);
+    cmd.args(["run", "get-by-id", "--id", "meshde"]);
+    cmd.assert().failure().stderr("env not recognized\n");
+}