Skip to content

fix(registry): guard against nil logger in RelationshipCSVHelper - #1086

Open
Omkar-Ugal wants to merge 1 commit into
meshery:masterfrom
Omkar-Ugal:fix/relationshipcsvhelper-nil-log
Open

fix(registry): guard against nil logger in RelationshipCSVHelper#1086
Omkar-Ugal wants to merge 1 commit into
meshery:masterfrom
Omkar-Ugal:fix/relationshipcsvhelper-nil-log

Conversation

@Omkar-Ugal

@Omkar-Ugal Omkar-Ugal commented Aug 7, 2026

Copy link
Copy Markdown
Member

Description
This fixes a nil pointer panic in RelationshipCSVHelper.ParseRelationshipsSheet() when Log is not initialized.

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Bug Fixes
    • Improved relationship parsing stability when logging is unavailable.
    • Parsing errors continue to be returned correctly without causing additional failures.

Signed-off-by: Omkar Ugalmugle <omkarugalmugle285@gmail.com>
@welcome

welcome Bot commented Aug 7, 2026

Copy link
Copy Markdown

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Relationship parsing now guards informational and error logging with nil checks. Parsing errors remain returned to the caller.

Changes

Relationship parsing

Layer / File(s) Summary
Guard relationship parsing logs
registry/relationship.go
The parser logs informational messages and parsing errors only when Log is initialized. Parsing errors remain returned.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: codeahmedjamil

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the nil logger guard added to RelationshipCSVHelper, which matches the main change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant