Skip to content

fix: use correct JSR specifier for @meshtastic/protobufs#1028

Open
danditomaso wants to merge 1 commit intomeshtastic:mainfrom
danditomaso:fix/protobuf-package-specifier
Open

fix: use correct JSR specifier for @meshtastic/protobufs#1028
danditomaso wants to merge 1 commit intomeshtastic:mainfrom
danditomaso:fix/protobuf-package-specifier

Conversation

@danditomaso
Copy link
Collaborator

Summary

  • Fix the @meshtastic/protobufs dependency specifier to use the full JSR format (jsr:@meshtastic/protobufs@^2.7.18) instead of the shorthand
  • Pin pnpm version to 10.17.0 in CI workflows for reproducible builds
  • Remove unused .npmrc (JSR registry config no longer needed with correct specifier)

Test plan

  • Verify pnpm install resolves correctly
  • Verify CI builds pass with pinned pnpm version

Pin pnpm version in CI workflows, remove unused .npmrc, and fix the
protobufs dependency specifier to use the full JSR format.
Copilot AI review requested due to automatic review settings March 12, 2026 02:04
@vercel
Copy link

vercel bot commented Mar 12, 2026

@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s dependency and CI configuration to correctly consume @meshtastic/protobufs from JSR and make pnpm installs more reproducible in CI.

Changes:

  • Fix @meshtastic/protobufs to use the full JSR specifier format (jsr:@meshtastic/protobufs@^2.7.18).
  • Pin pnpm to 10.17.0 in PR and main-branch CI workflows.
  • Remove the root .npmrc JSR registry override.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
package.json Corrects the JSR dependency specifier for @meshtastic/protobufs.
.npmrc Removes the JSR registry config entry now deemed unnecessary.
.github/workflows/pr.yml Pins pnpm version to 10.17.0 for PR CI reproducibility.
.github/workflows/ci.yml Pins pnpm version to 10.17.0 for main branch CI reproducibility.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants