fix: use correct JSR specifier for @meshtastic/protobufs#1028
Open
danditomaso wants to merge 1 commit intomeshtastic:mainfrom
Open
fix: use correct JSR specifier for @meshtastic/protobufs#1028danditomaso wants to merge 1 commit intomeshtastic:mainfrom
danditomaso wants to merge 1 commit intomeshtastic:mainfrom
Conversation
Pin pnpm version in CI workflows, remove unused .npmrc, and fix the protobufs dependency specifier to use the full JSR format.
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo’s dependency and CI configuration to correctly consume @meshtastic/protobufs from JSR and make pnpm installs more reproducible in CI.
Changes:
- Fix
@meshtastic/protobufsto use the full JSR specifier format (jsr:@meshtastic/protobufs@^2.7.18). - Pin
pnpmto10.17.0in PR and main-branch CI workflows. - Remove the root
.npmrcJSR registry override.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Corrects the JSR dependency specifier for @meshtastic/protobufs. |
| .npmrc | Removes the JSR registry config entry now deemed unnecessary. |
| .github/workflows/pr.yml | Pins pnpm version to 10.17.0 for PR CI reproducibility. |
| .github/workflows/ci.yml | Pins pnpm version to 10.17.0 for main branch CI reproducibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@meshtastic/protobufsdependency specifier to use the full JSR format (jsr:@meshtastic/protobufs@^2.7.18) instead of the shorthand10.17.0in CI workflows for reproducible builds.npmrc(JSR registry config no longer needed with correct specifier)Test plan
pnpm installresolves correctly