enable graph colltrace in ncclx/ctran wrappers (#1979)#1979
Open
dolpm wants to merge 7 commits intometa-pytorch:mainfrom
Open
enable graph colltrace in ncclx/ctran wrappers (#1979)#1979dolpm wants to merge 7 commits intometa-pytorch:mainfrom
dolpm wants to merge 7 commits intometa-pytorch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
Summary: we should support multiple current collectives - this is possible when multiple collectives are being executed across ctran/nc cl-baseline communicators, or we have collectives that require concurrency (e.g., signals) Differential Revision: D98955440
Summary: we're adding support for multiple concurrent collectives. it's possible we have 2 events progressing at the same time. if the calls to the processing handler oscillate, we will hit the &curEvent != lastEvent_ which will reset the timeout (instead of keeping the timers independent per event) Differential Revision: D98980980
Differential Revision: D99015585
Differential Revision: D99015610
Differential Revision: D100045250
Summary: Pull Request resolved: meta-pytorch#1980 ``` Graph CollTrace overhead (~200us D2D collectives, 500 replays): N=1 Baseline: 138.7us CollTrace: 151.5us Overhead: +9.2% N=10 Baseline: 1365.8us CollTrace: 1385.4us Overhead: +1.4% N=100 Baseline: 13631.5us CollTrace: 13736.7us Overhead: +0.8% ``` Differential Revision: D97960551
Summary: Pull Request resolved: meta-pytorch#1979 re-enable graph support in colltracewrappers Reviewed By: SuhitK Differential Revision: D98966415
meta-codesync
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
re-enable graph support in colltracewrappers
Reviewed By: SuhitK
Differential Revision: D98966415