Open
Conversation
Summary: We need to align AGP's internal persistent request with the window API so that regular AllGather can be converted to AGP in graph capture mode (window init + dry-run exec at capture time, SM-free CE replay at execution time). In this diff, we extract `initResources` to a public func so that window AGP can directly call it Reviewed By: dsjohns2 Differential Revision: D99514784
Summary:
Enables window based AGP using the same SM-free CE+IB algorithm as the persistent AGP path, the memory registration & handler exchange is handled by window, while the core algorithm is reusing the existing AGP. The work flow is as following:
```
cudaMalloc()
→ user allocates recv buffer
│
ctranWinRegister()
→ register buffer with window
│
exchange()
→ populates remWinInfo with remote addresses and keys
│
allGatherWinInit()
→ pArgs.recvbuff = win->winDataPtr
→ pArgs.recvHdl = win->dataRegHdl
→ pArgs.remoteRecvBuffs[r] = win->remWinInfo[r].dataAddr
→ pArgs.remoteAccessKeys[r]= win->remWinInfo[r].dataRkey
→ pArgs.initialized = true (skip waitInit)
→ initResources() (allocate pipeSync)
│
allGatherWinExec()
→ algo->execDirect() or algo->execPipeline()
→ same code path as legacy persistent AGP
│
allGatherWinDestroy()
→ algo->destroy(), free resources
```
Reviewed By: dsjohns2
Differential Revision: D99771595
Differential Revision: D99930047
meta-cla
bot
added
the
CLA Signed
Contributor
|
@tianfengfrank has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99930047. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D99930047