Add ForkBasedTestDriver for fork+exec multi-process tests (#2006)#2006
Open
Scusemua wants to merge 1 commit intometa-pytorch:mainfrom
Open
Add ForkBasedTestDriver for fork+exec multi-process tests (#2006)#2006Scusemua wants to merge 1 commit intometa-pytorch:mainfrom
Scusemua wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
@Scusemua has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100079492. |
meta-codesync
bot
changed the title
Scusemua
added a commit
to Scusemua/torchcomms
that referenced
this pull request
Apr 9, 2026
…ch#2006) Summary: Introduce a lightweight fork+exec test driver that re-execs the test binary as worker subprocesses with TCPStore-based coordination. This enables ncclx tests to inspect worker exit codes (e.g., watchdog crash tests) without depending on MCCL's heavier Thrift-based `CollectiveIntegrationTestMixin`. Also adds unit tests (`ForkBasedTestDriverTest.cc`) covering: - Basic multi-rank success with KV round-trip - Exact exit code capture - Signal-terminated worker reporting (128 + signal) Differential Revision: D100079492
Scusemua
force-pushed
the
export-D100079492
branch
from
837130b to
93f7aa0
Compare
…ch#2006) Summary: Pull Request resolved: meta-pytorch#2006 Introduce a lightweight fork+exec test driver that re-execs the test binary as worker subprocesses with TCPStore-based coordination. This enables ncclx tests to inspect worker exit codes (e.g., watchdog crash tests) without depending on MCCL's heavier Thrift-based `CollectiveIntegrationTestMixin`. Also adds unit tests (`ForkBasedTestDriverTest.cc`) covering: - Basic multi-rank success with KV round-trip - Exact exit code capture - Signal-terminated worker reporting (128 + signal) Differential Revision: D100079492
Scusemua
force-pushed
the
export-D100079492
branch
from
93f7aa0 to
110ca12
Compare
Scusemua
added a commit
to Scusemua/torchcomms
that referenced
this pull request
Apr 9, 2026
…ch#2006) Summary: Introduce a lightweight fork+exec test driver that re-execs the test binary as worker subprocesses with TCPStore-based coordination. This enables ncclx tests to inspect worker exit codes (e.g., watchdog crash tests) without depending on MCCL's heavier Thrift-based `CollectiveIntegrationTestMixin`. Also adds unit tests (`ForkBasedTestDriverTest.cc`) covering: - Basic multi-rank success with KV round-trip - Exact exit code capture - Signal-terminated worker reporting (128 + signal) Differential Revision: D100079492
Scusemua
added a commit
to Scusemua/torchcomms
that referenced
this pull request
Apr 9, 2026
…ch#2006) Summary: Introduce a lightweight fork+exec test driver that re-execs the test binary as worker subprocesses with TCPStore-based coordination. This enables ncclx tests to inspect worker exit codes (e.g., watchdog crash tests) without depending on MCCL's heavier Thrift-based `CollectiveIntegrationTestMixin`. Also adds unit tests (`ForkBasedTestDriverTest.cc`) covering: - Basic multi-rank success with KV round-trip - Exact exit code capture - Signal-terminated worker reporting (128 + signal) Differential Revision: D100079492
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Introduce a lightweight fork+exec test driver that re-execs the test binary as worker subprocesses with TCPStore-based coordination. This enables ncclx tests to inspect worker exit codes (e.g., watchdog crash tests) without depending on MCCL's heavier Thrift-based
CollectiveIntegrationTestMixin.Also adds unit tests (
ForkBasedTestDriverTest.cc) covering:Differential Revision: D100079492