Fix comm_cuda_init_mp_test ImportError handling in forkserver child#2015
Open
lilyjanjigian wants to merge 2 commits intometa-pytorch:mainfrom
Open
Fix comm_cuda_init_mp_test ImportError handling in forkserver child#2015lilyjanjigian wants to merge 2 commits intometa-pytorch:mainfrom
lilyjanjigian wants to merge 2 commits intometa-pytorch:mainfrom
Conversation
…orch#2012) Summary: The NCCL_RUNTIME_CONNECT CVAR default was changed to 1 (true), but the NoHintsCreatesDefaults test still expected false. Update the assertion to match the current default. Reviewed By: MogicianWu Differential Revision: D100182677
Summary: The forkserver child process can fail with ImportError (not just ModuleNotFoundError) due to numpy circular import issues in the PAR environment. Catch the broader ImportError to handle both cases. Differential Revision: D100205289
meta-cla
bot
added
the
CLA Signed
Contributor
|
@lilyjanjigian has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100205289. |
lilyjanjigian
added a commit
to lilyjanjigian/torchcomms
that referenced
this pull request
Apr 9, 2026
…eta-pytorch#2015) Summary: The forkserver child process can fail with ImportError (not just ModuleNotFoundError) due to numpy circular import issues in the PAR environment. Catch the broader ImportError to handle both cases. Differential Revision: D100205289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The forkserver child process can fail with ImportError (not just
ModuleNotFoundError) due to numpy circular import issues in the PAR
environment. Catch the broader ImportError to handle both cases.
Differential Revision: D100205289