Fix #1267: [torchx/schedulers] Add support for kueue_scheduler#1276
Open
JiwaniZakir wants to merge 1 commit intometa-pytorch:mainfrom
Open
Fix #1267: [torchx/schedulers] Add support for kueue_scheduler#1276JiwaniZakir wants to merge 1 commit intometa-pytorch:mainfrom
kueue_scheduler#1276JiwaniZakir wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kiukchung
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1267
Adds
KueueScheduleras a namespace-package plugin undertorchx_plugins/schedulers/kueue.py, implementing the plugin architecture described in the issue.KueueSchedulersubclassesKubernetesSchedulerand overrides_submit_dryrunto inject thekueue.x-k8s.io/queue-namelabel into the job resource metadata before submission. The queue name is read fromcfg.get("queue"), defaulting to"default"if unset. The factory functionkueue_scheduleris registered via@register.scheduler(name="kueue"), making it auto-discoverable at runtime when the wheel containingtorchx_plugins/is installed.Test plan:
Two unit tests added to
torchx/schedulers/test/kubernetes_scheduler_test.pyunderKueueSchedulerTest:test_factory_returns_kueue_scheduler: callskueue_scheduler(session_name="test")and asserts the returned object is aKueueSchedulerinstance withsession_name == "test".test_queue_label_added_to_metadata: patchesKubernetesScheduler._submit_dryrunwith aMagicMock, invokesKueueScheduler(session_name="test")._submit_dryrunwithOpts(queue="my-kueue-queue"), and asserts thatresource["metadata"]["labels"]["kueue.x-k8s.io/queue-name"] == "my-kueue-queue"and that the originaldryrun_infoobject is returned unmodified.This PR was created with AI assistance (Claude). The changes were reviewed by quality gates and a critic model before submission.