test(node_napi): Add a Regression Test#34
Merged
Conversation
Adds tests for Node.js NAPI module support using rspack. This includes a new batch file for running the tests and JavaScript and command files for the Node.js NAPI test case. This test is expected to fail until MetaCall's node.dll properly re-exports napi_* symbols"hypo".
k5602
force-pushed
the
master
branch
2 times, most recently
from
60f4a59 to
6cb18b1
Compare
viferga
reviewed
Mar 17, 2026
| rem TODO: NAPI native addon support - napi_* symbols not re-exported by MetaCall's node.dll | ||
| rem TODO: https://github.com/metacall/distributable-windows/issues/ | ||
| echo Npm Install rspack Test | ||
| call metacall npm install --prefix="%loc%\node_napi" @rspack/core |
| echo Node NAPI Tests | ||
| set "LOADER_SCRIPT_PATH=%loc%\node_napi" | ||
|
|
||
| rem TODO: NAPI native addon support - napi_* symbols not re-exported by MetaCall's node.dll |
|
|
||
| // Regression test for MetaCall NAPI native addon support. | ||
| // @rspack/core depends on @rspack/binding, a Rust-compiled NAPI addon (napi-rs). | ||
| // MetaCall's embedded node.dll must re-export all napi_* symbols for this to work. |
Member
There was a problem hiding this comment.
all comments down here are wrong, kust link the pr in the core
Contributor
Author
|
@viferga |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for Node.js NAPI module support using rspack. This includes a new batch file for running the tests and JavaScript and command files for the Node.js NAPI test case. This test is expected to fail until MetaCall's node.dll properly re-exports napi_* symbols"hypo".