docs(agent-context): activate reverse-nav-finder guidance + audit check (ADR-0038 Wave 4)#134
Merged
Conversation
…reverseName exemption ADR-0038 (ADR-0036 Wave 4) shipped reverse navigation as explicit generated FK finders (find<Source>By<FkField> + batched …In), with NO @reverseName attribute — the finder name derives from source + FK field, unique by construction. Reconcile the agent-context surfaces to what shipped: - authoring skill: replace the Wave-4 TODO with live guidance — reverse navigation is generated for you (performant, framework-free; two FKs to one target → two distinct finders); no attribute to author (codegen feature, not a metamodel attr). - audit skill: move the reverse-nav item into the active vocabulary-hygiene/ modernization advisory — flag hand-rolled findByParentId / WHERE fk = ? repository helpers and recommend the generated reverse FK finder. Advisory, not a failure. - grounding test: drop @reverseName from DELIBERATELY_NAMED_RETIRED_OR_CUT (the predicted-but-never-built attr is no longer named by the skills, so needs no exemption). No remaining Wave-4 TODO markers reference @reverseName. - regenerate the agent-context conformance goldens (4 stacks). Conformance + drift + capability-grounding all green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GF9xLEQZaPus5Y6opk398n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconciles the agent-context to what shipped: reverse navigation as generated explicit FK finders (no @reverseName attribute). Authoring skill teaches it as a codegen feature (performant, framework-free, auto-disambiguated); audit gains an advisory check flagging hand-rolled reverse-query repository helpers. Removed @reverseName from the grounding exemption (never built). 13/13 conformance/drift/grounding green.
🤖 Generated with Claude Code