ci(ts): 30s test timeout for the cli conformance suite (eliminate cold-start flake class)#169
Merged
Merged
Conversation
… flake) gate_conf_ts runs the cli suite via `cd packages/cli && bun test` under bun's default 5s per-test timeout. The cli tests invoke full `meta`/run() dispatch, which lazily imports each command's (sometimes heavy: codegen, migrate-ts) module on first use; on a cold/contended self-hosted runner that first cold-start import can exceed 5s and flake otherwise-instant exit-code/--format tests (seen twice on the main push path: help-and-exit and index-format, each failing at ~5001ms while the whole suite runs in ~1.3s warm). bun does NOT honor bunfig.toml `[test] timeout` (verified: a 1ms config value had no effect), so the fix is the `--timeout` CLI flag on the invocation. 30s keeps a genuine hang loud while removing the timing sensitivity. Same root cause as the sidecar readiness fix (#167) — tight timeouts tripping under host contention. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ew1XfYSbEAezxjs9opynAe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gate_conf_tsruns the cli suite viacd packages/cli && bun testunder bun's default 5s per-test timeout. The cli tests invoke fullmeta/run()dispatch, which lazily imports each command's (sometimes heavy — codegen, migrate-ts) module on first use. On a cold/contended self-hosted runner that first cold-start import can exceed 5s and flake otherwise-instant exit-code/--formattests — seen twice on the main push path (help-and-exit,index-format), each failing at ~5001ms while the whole suite runs in ~1.3s warm.Why the CLI flag (not config): bun does not honor
bunfig.toml [test] timeout— verified empirically (a 1ms config value had no effect on tests run from eithercli/orserver/typescript/). So the fix is--timeout 30000on the invocation.30s keeps a genuine hang loud while removing the timing sensitivity for tests that assert behavior, not performance. This covers the whole cli suite (both previously-flaky files and any future cold-start-sensitive ones), not just one file. Same root cause as the sidecar readiness fix (#167) — tight timeouts tripping under host contention.
🤖 Generated with Claude Code