feat(docs-site): render a field's view.* subtypes + their attrs#177
Merged
Conversation
Object pages now show each field's presentation view children (view.currency / view.badge / view.meter / view.duration / …) and their attributes — a per-field sub-row listing `view.<subType>` badges and `@attr=value` pairs (@variantMap and other object-valued attrs render as sorted `k: v` lists). The field builder consumes the view node + its ownAttrs, so they no longer surface as "not rendered by any page" in coverage. Attrs are read directly off each view node, so custom view subtypes (registered via extraProviders) render their attrs from a bare registration — no per-attr schema duplication needed in the consumer's provider. The acme fixture gains a view.currency field (Product.priceCents) exercising the new sub-row; golden regenerated. Determinism preserved (view attrs sorted). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object pages now show each field's presentation view children (
view.currency/view.badge/view.meter/view.duration/…) + their attributes as a per-field sub-row (view.<subType>badges +@attr=value; object attrs like@variantMaprender as sortedk: vlists). The field builder consumes the view node +ownAttrs, so they're no longer flagged "not rendered" in coverage.Attrs read directly off the node, so custom view subtypes (via
extraProviders) render their attrs from a bare registration — no per-attr schema duplication in the consumer. acme fixture gains aview.currencyfield; golden regenerated (deterministic). Dogfooded on a real model — view rows render on every field that has them.🤖 Generated with Claude Code