Open
Conversation
Member
I'll rebase the v0.2.0 branch on main once this is merged so that should be OK. AFAIK it's bad until 2.9 though so probably not going to help. Once ci is green this looks good, but there seem to be some spurious changes in the diff? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already had to do it in metatomic for adding unconditional vesin support (metatensor/metatomic#159), and tests in #1058 are failing for torch 2.1. So let's also do it here.
@HaoZeke do we need to change something in dlpack integration as well?
Contributor (creator of pull-request) checklist
Reviewer checklist