Skip to content

Vicinity CLI using option to prevent addition of cell method#121

Open
bayliffe wants to merge 4 commits intomasterfrom
lighting_cell_method_fix
Open

Vicinity CLI using option to prevent addition of cell method#121
bayliffe wants to merge 4 commits intomasterfrom
lighting_cell_method_fix

Conversation

@bayliffe
Copy link
Contributor

@bayliffe bayliffe commented Feb 6, 2026

Test of vicinity CLI applied using option to exclude the addition of an area cell method.
Data is a simple copy of the existing kgo_10000.nc file without the cell_method present.

probability_of_number_of_lightning_flashes_per_unit_area_in_vicinity_above_threshold / (1) (realization: 4; projection_y_coordinate: 100; projection_x_coordinate: 100)
    Dimension coordinates:
        realization                                                                                    x                           -                             -
        projection_y_coordinate                                                                        -                           x                             -
        projection_x_coordinate                                                                        -                           -                             x
    Scalar coordinates:
        forecast_period                                                                    7200 seconds, bound=(3600, 7200) seconds
        forecast_reference_time                                                            2022-06-28 00:00:00
        number_of_lightning_flashes_per_unit_area                                          0.0 m-2
        radius_of_vicinity                                                                 10000.0 m
        time                                                                               2022-06-28 02:00:00, bound=(2022-06-28 01:00:00, 2022-06-28 02:00:00)
    Attributes:
        Conventions                                                                        'CF-1.7'
        institution                                                                        'Met Office'
        mosg__model_configuration                                                          'gl_ens'
        source                                                                             'Met Office Unified Model'
        title                                                                              'MOGREPS-G Forecast on UK 2 km Standard Grid'

…utes oscillate in length rather than any change being consistent along the time dimension.
@cpelley
Copy link

cpelley commented Feb 9, 2026

perhaps change to targeting your new 1.17.x branch??
(then merge 1.17.x into master after this is merged perhaps)

@gavinevans
Copy link
Contributor

For clarity, with this improver PR targeting master directly: metoppv/improver#2296, both this PR (targeting master) and #122 are required.

gavinevans
gavinevans previously approved these changes Feb 16, 2026
Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bayliffe 👍

Copy link
Member

@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs the changes from #122 adding in as well so that the tests associated with metoppv/improver#2296 can all pass.

* mobt1061:
  Modify cell method for lightning KGO to use lower case s.
  Modal weather symbols test data for case where mosg__model_run attributes oscillate in length rather than any change being consistent along the time dimension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments