Remove redundant conditional in julia-launcher#19
Open
PranavGadge01 wants to merge 1 commit intomgubi:mainfrom
Open
Remove redundant conditional in julia-launcher#19PranavGadge01 wants to merge 1 commit intomgubi:mainfrom
PranavGadge01 wants to merge 1 commit intomgubi:mainfrom
Conversation
Author
|
@hammerfunctor could u please check... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
julia-launcherfunction inprogs/init-julia.scmcontainedan if/else where both branches produced identical output:
This conditional is dead code — it never influences the return value
regardless of whether Julia is found or not.
Additionally, the false branch is structurally unreachable. The
:require (url-exists-in-path? "julia")clause inplugin-configureruns before the launcher is ever invoked. If Julia is absent from PATH,
TeXmacs disables the plugin entirely at that point and never calls
julia-launcher.Fix
Simplify
julia-launcherto a single expression:Impact
No runtime behaviour change. This is a code clarity fix — the
previous code falsely implied error handling logic was present
when it was not.