fix: treat empty request body as POST#81
Draft
leno23 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"", empty buffers, etc.) as a present body when inferring the default HTTP method.null/undefinedas no-body values so requests without a body still default toGET.POST.Related Issues / Closes
Closes #54
Testing
TypeError: Request with GET/HEAD method cannot have body.node run-param-tests.mjs— passed (temporary focused Rollup runner fortest/paramTests.js, removed before commit)npm run lint -- --quiet— passedgit diff --check— passedAI assistance disclosure
This draft PR was prepared by Hermes Agent as an automated maintainer-assist change. A human maintainer should review before marking ready or merging.