Skip to content

Fix Windows debug builds #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arr2036 merged 2 commits into from
Oct 10, 2025
Merged

Fix Windows debug builds #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3699a2
Add debug build to Windows CI
timwoj Oct 10, 2025
10953b5
Revert checking return code from mutex unlocking on Windows
timwoj Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,18 @@ jobs:
timeout-minutes: 5
runs-on: windows-2022
name: CI-windows (build)
strategy:
matrix:
build_type: [Release, Debug]

steps:
- uses: actions/checkout@v2

- name: Configure build system
run: |
cmake --version
cmake -S . -B build_x64 -A x64 -G "Visual Studio 17 2022" -DSTATICLIB=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_VERBOSE_MAKEFILE=ON
cmake -S . -B build_x64 -A x64 -G "Visual Studio 17 2022" -DSTATICLIB=ON -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DCMAKE_VERBOSE_MAKEFILE=ON

- name: Build libkqueue
run: |
cmake --build build_x64 --target install --config Release --parallel 1
cmake --build build_x64 --target install --config ${{ matrix.build_type }} --parallel 1
9 changes: 9 additions & 0 deletions src/common/debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,14 @@ typedef struct {
} \
} while (0)

#ifdef _WIN32
# define tracing_mutex_unlock(x) do { \
(x)->mtx_status = MTX_UNLOCKED; \
(x)->mtx_owner = -1; \
pthread_mutex_unlock(&((x)->mtx_lock)); \
dbg_printf("[%i]: unlocked %s", __LINE__, # x); \
} while (0)
#else
# define tracing_mutex_unlock(x) do { \
(x)->mtx_status = MTX_UNLOCKED; \
(x)->mtx_owner = -1; \
Expand All @@ -153,6 +161,7 @@ typedef struct {
}; \
dbg_printf("[%i]: unlocked %s", __LINE__, # x); \
} while (0)
#endif

typedef void (*dbg_func_t)(char const *fmt, ...);

Expand Down
Loading