throw error if no pipeline#17
Open
jimsheldon wants to merge 2 commits intomicroadam:masterfrom
meltwater:return-204
Open
throw error if no pipeline#17jimsheldon wants to merge 2 commits intomicroadam:masterfrom meltwater:return-204
jimsheldon wants to merge 2 commits intomicroadam:masterfrom
meltwater:return-204
Conversation
Author
|
This should fix #14 |
Owner
|
Hi @jimsheldon. Thanks for the contribution. I am not sure this will work though, as this seems to assume that there will only be ONE yaml doc in the drone file. There could be multiple pipelines or even things like: This PR assumes that it will only contain ONE yaml doc, so if you used a |
Author
|
Thanks @microadam we will look into this |
if 'kind' is undefined, the config could be 0.8 syntax, so return a 204 and let the drone server retrieve it if 'kind' is anything other than 'pipeline', return it
Author
|
@microadam I pushed a fix that should handle non-pipeline kinds properly |
krishna-koushik
approved these changes
Oct 14, 2019
Owner
|
Thanks for this! I will try and have a proper look through this soon. I really need to get some unit tests on this project so we can ensure no existing functionality breaks with little changes like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.