Releases: BlinkId/v7.7.4, BlinkIdVerify/v3.20.1, BlinkCard/v3000.0.5#37
Merged
nnstanusic merged 1 commit intomainfrom Apr 16, 2026
Merged
Releases: BlinkId/v7.7.4, BlinkIdVerify/v3.20.1, BlinkCard/v3000.0.5#37nnstanusic merged 1 commit intomainfrom
nnstanusic merged 1 commit intomainfrom
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 25 minutes and 52 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (25)
📒 Files selected for processing (63)
📝 WalkthroughWalkthroughThis PR updates analytics schemas to version 2.0.0 with breaking schema changes across multiple dependent packages. It integrates analytics logging for "DocumentNotSupported" alerts in UI managers, introduces two new scanning configuration options, and documents C++ native dependencies for WebAssembly builds. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (4)
docs/blinkid-verify/OssDependencies.md (1)
157-157: Consider hyphenating compound adjectives for clarity.
For Line 157 and Line 166, “high-performance” reads cleaner than “high performance” before a noun.Also applies to: 166-166
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/blinkid-verify/OssDependencies.md` at line 157, Update the compound adjective "high performance" to "high-performance" in the OSS dependency descriptions; specifically edit the table entry for kiwaku (the line containing "kiwaku/20230809.4@microblink/main#6e5eb5cb85661173d4d516738282e5db | BSL-1.0 | [Link](https://github.com/microblink/kiwaku) | C++20 and onward collection of high performance data containers and related tools") and the similar entry on the later occurrence (line referenced in the review), changing "high performance" to "high-performance" so the phrase correctly hyphenates the compound adjective before the noun.packages/blinkid-verify-worker/CHANGELOG.md (1)
7-7: Consider specifying the new schema version.The changelog mentions bumping the tracked schema version but doesn't specify the new version (1.2.0). Adding "to 1.2.0" would improve clarity for future reference.
📝 Suggested improvement
-- Bumped tracked schema version for the `ping.sdk.init.start` +- Bumped tracked schema version for the `ping.sdk.init.start` to 1.2.0🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/blinkid-verify-worker/CHANGELOG.md` at line 7, Update the CHANGELOG entry that currently reads "Bumped tracked schema version for the `ping.sdk.init.start`" to explicitly include the new version number by changing it to "Bumped tracked schema version for the `ping.sdk.init.start` to 1.2.0" so the new schema version is clear for future reference.packages/analytics/src/AnalyticService.test.ts (1)
203-215: Consider adding a dedicated alert test forDocumentNotSupported.Given the new
AlertTypevalue, one explicit case here would prevent silent regressions at the API boundary.Proposed test addition
describe("alert events", () => { it("should log alert event", async () => { await analyticsService.logAlertDisplayedEvent("NetworkError"); @@ }); }); + + it("should log DocumentNotSupported alert event", async () => { + await analyticsService.logAlertDisplayedEvent("DocumentNotSupported"); + + expect(mockPingFn).toHaveBeenCalledWith({ + schemaName: "ping.sdk.ux.event", + schemaVersion: "1.1.0", + data: { + eventType: "AlertDisplayed", + alertType: "DocumentNotSupported", + }, + }); + }); });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/analytics/src/AnalyticService.test.ts` around lines 203 - 215, Add a dedicated unit test that calls analyticsService.logAlertDisplayedEvent with the new AlertType value "DocumentNotSupported" and asserts mockPingFn was invoked with the same ping payload shape as the existing test: schemaName "ping.sdk.ux.event", schemaVersion "1.1.0", and data containing eventType "AlertDisplayed" and alertType "DocumentNotSupported". Place the new it(...) alongside the existing "should log alert event" test in AnalyticService.test.ts and reuse the same mock setup (mockPingFn) to ensure the API boundary doesn't regress for the new AlertType.packages/blinkid-verify-wasm/CHANGELOG.md (1)
8-10: Consider documenting default values for new scanning flags.Lines 8–10 describe behavior when enabled/disabled, but not explicit defaults. Adding
(default: false)(or actual defaults) would make upgrade impact clearer.Suggested changelog wording tweak
- - `scanPassportDataPageOnly` - when enabled, only the passport data page (containing `MRZ`) is scanned; when disabled, scanning of the second page is required for certain passports - - `scanUnsupportedBack` - when enabled, the back side of documents whose back side is not supported will also be scanned + - `scanPassportDataPageOnly` (default: false) - when enabled, only the passport data page (containing `MRZ`) is scanned; when disabled, scanning of the second page is required for certain passports + - `scanUnsupportedBack` (default: false) - when enabled, the back side of documents whose back side is not supported will also be scanned🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/blinkid-verify-wasm/CHANGELOG.md` around lines 8 - 10, Update the CHANGELOG entry to include the default boolean values for the new ScanningSettings flags so consumers know upgrade behavior; explicitly state the defaults for ScanningSettings.scanPassportDataPageOnly and ScanningSettings.scanUnsupportedBack (for example: “scanPassportDataPageOnly (default: false)” and “scanUnsupportedBack (default: false)”), and keep the existing enabled/disabled descriptions intact so it reads: name, short description, and default value.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/blinkid-verify/OssDependencies.md`:
- Line 9: Update the summary sentence that currently reads "**C++
Dependencies**: Native dependencies for WebAssembly builds (33 unique packages
across 1 build flavors)" to use the singular form "build flavor" instead of
"build flavors" so it reads "(33 unique packages across 1 build flavor)"; locate
this exact string in the docs and correct the wording.
- Around line 146-178: The table rows currently use identical link text
"[Link](...)" (e.g., entries like
abseil/20250512.0.1@microblink/main#120e2c1b766e76087248ee491d67cb52,
adv_obfuscator/20170904.1@microblink/main#aa4c2ce...,
boost/1.84.1@microblink/main#bff79afe..., etc.), which triggers markdownlint
MD059; update each markdown link label in OssDependencies.md to a descriptive,
package- or repository-specific text (for example use "abseil-cpp",
"ADVobfuscator", "boost", "concurrentqueue", "config_ex", etc.) instead of the
generic "Link" so each row's URL column is unique and accessible while
preserving the existing URLs.
In `@packages/analytics/CHANGELOG.md`:
- Line 7: The release note sentence currently reads "Updated analytics to new
schema intoducing breaking changes in previousy used schemas." — fix the typos
and clarify the phrasing by replacing it with a corrected sentence such as:
"Updated analytics schema; this introduces breaking changes to previously used
schemas." Locate and update the sentence in CHANGELOG.md (the line containing
the original sentence) so spelling is corrected and the meaning is clearer.
In `@packages/blinkcard-core/CHANGELOG.md`:
- Around line 5-11: The changelog labels the release as a patch while
`@microblink/analytics` was bumped to 2.0.0 and blinkcard-core re-exports
analytics types/services (see packages/blinkcard-core/src/index.ts where
analytics types/services are re-exported), which likely introduces a breaking
change; update the release classification and versioning: re-evaluate semver
impact, change CHANGELOG.md and the package.json version for
`@microblink/blinkcard-core` from patch to a compatible major/minor release (or
pin the analytics dependency to a non-breaking version), and ensure the release
notes explicitly document the breaking API (or revert the re-export) so
consumers are not surprised.
---
Nitpick comments:
In `@docs/blinkid-verify/OssDependencies.md`:
- Line 157: Update the compound adjective "high performance" to
"high-performance" in the OSS dependency descriptions; specifically edit the
table entry for kiwaku (the line containing
"kiwaku/20230809.4@microblink/main#6e5eb5cb85661173d4d516738282e5db | BSL-1.0 |
[Link](https://github.com/microblink/kiwaku) | C++20 and onward collection of
high performance data containers and related tools") and the similar entry on
the later occurrence (line referenced in the review), changing "high
performance" to "high-performance" so the phrase correctly hyphenates the
compound adjective before the noun.
In `@packages/analytics/src/AnalyticService.test.ts`:
- Around line 203-215: Add a dedicated unit test that calls
analyticsService.logAlertDisplayedEvent with the new AlertType value
"DocumentNotSupported" and asserts mockPingFn was invoked with the same ping
payload shape as the existing test: schemaName "ping.sdk.ux.event",
schemaVersion "1.1.0", and data containing eventType "AlertDisplayed" and
alertType "DocumentNotSupported". Place the new it(...) alongside the existing
"should log alert event" test in AnalyticService.test.ts and reuse the same mock
setup (mockPingFn) to ensure the API boundary doesn't regress for the new
AlertType.
In `@packages/blinkid-verify-wasm/CHANGELOG.md`:
- Around line 8-10: Update the CHANGELOG entry to include the default boolean
values for the new ScanningSettings flags so consumers know upgrade behavior;
explicitly state the defaults for ScanningSettings.scanPassportDataPageOnly and
ScanningSettings.scanUnsupportedBack (for example: “scanPassportDataPageOnly
(default: false)” and “scanUnsupportedBack (default: false)”), and keep the
existing enabled/disabled descriptions intact so it reads: name, short
description, and default value.
In `@packages/blinkid-verify-worker/CHANGELOG.md`:
- Line 7: Update the CHANGELOG entry that currently reads "Bumped tracked schema
version for the `ping.sdk.init.start`" to explicitly include the new version
number by changing it to "Bumped tracked schema version for the
`ping.sdk.init.start` to 1.2.0" so the new schema version is clear for future
reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 16bfd8ff-200e-46f7-94db-d0a624f9ec21
⛔ Files ignored due to path filters (25)
packages/blinkcard-wasm/dist/advanced-threads/BlinkCardModule.jsis excluded by!**/dist/**packages/blinkcard-wasm/dist/advanced-threads/BlinkCardModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkcard-wasm/dist/advanced/BlinkCardModule.jsis excluded by!**/dist/**packages/blinkcard-wasm/dist/advanced/BlinkCardModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkcard-wasm/dist/basic/BlinkCardModule.jsis excluded by!**/dist/**packages/blinkcard-wasm/dist/basic/BlinkCardModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkcard-wasm/dist/size-manifest.jsonis excluded by!**/dist/**packages/blinkid-verify-wasm/dist/advanced-threads/BlinkIdVerifyModule.jsis excluded by!**/dist/**packages/blinkid-verify-wasm/dist/advanced-threads/BlinkIdVerifyModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkid-verify-wasm/dist/advanced/BlinkIdVerifyModule.jsis excluded by!**/dist/**packages/blinkid-verify-wasm/dist/advanced/BlinkIdVerifyModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkid-verify-wasm/dist/size-manifest.jsonis excluded by!**/dist/**packages/blinkid-wasm/dist/full/advanced-threads/BlinkIdModule.jsis excluded by!**/dist/**packages/blinkid-wasm/dist/full/advanced-threads/BlinkIdModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkid-wasm/dist/full/advanced/BlinkIdModule.jsis excluded by!**/dist/**packages/blinkid-wasm/dist/full/advanced/BlinkIdModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkid-wasm/dist/full/basic/BlinkIdModule.jsis excluded by!**/dist/**packages/blinkid-wasm/dist/full/basic/BlinkIdModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkid-wasm/dist/lightweight/advanced-threads/BlinkIdModule.jsis excluded by!**/dist/**packages/blinkid-wasm/dist/lightweight/advanced-threads/BlinkIdModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkid-wasm/dist/lightweight/advanced/BlinkIdModule.jsis excluded by!**/dist/**packages/blinkid-wasm/dist/lightweight/advanced/BlinkIdModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkid-wasm/dist/lightweight/basic/BlinkIdModule.jsis excluded by!**/dist/**packages/blinkid-wasm/dist/lightweight/basic/BlinkIdModule.wasmis excluded by!**/dist/**,!**/*.wasmpackages/blinkid-wasm/dist/size-manifest.jsonis excluded by!**/dist/**
📒 Files selected for processing (63)
docs/blinkid-verify/OssDependencies.mdpackages/analytics/CHANGELOG.mdpackages/analytics/package.jsonpackages/analytics/src/AnalyticService.test.tspackages/analytics/src/AnalyticService.tspackages/analytics/src/ping/ping.sdk.init.start.tspackages/analytics/src/ping/ping.sdk.ux.event.tspackages/blinkcard-core/CHANGELOG.mdpackages/blinkcard-core/docs/type-aliases/PingSdkInitStart.mdpackages/blinkcard-core/docs/type-aliases/PingUxEvent.mdpackages/blinkcard-core/package.jsonpackages/blinkcard-ux-manager/CHANGELOG.mdpackages/blinkcard-ux-manager/package.jsonpackages/blinkcard-wasm/CHANGELOG.mdpackages/blinkcard-wasm/package.jsonpackages/blinkcard-worker/CHANGELOG.mdpackages/blinkcard-worker/package.jsonpackages/blinkcard-worker/src/BlinkCardWorker.test.tspackages/blinkcard-worker/src/BlinkCardWorker.tspackages/blinkcard/CHANGELOG.mdpackages/blinkcard/docs/type-aliases/PingSdkInitStart.mdpackages/blinkcard/docs/type-aliases/PingUxEvent.mdpackages/blinkcard/package.jsonpackages/blinkid-core/CHANGELOG.mdpackages/blinkid-core/docs/type-aliases/PingSdkInitStart.mdpackages/blinkid-core/docs/type-aliases/PingUxEvent.mdpackages/blinkid-core/package.jsonpackages/blinkid-ux-manager/CHANGELOG.mdpackages/blinkid-ux-manager/package.jsonpackages/blinkid-ux-manager/src/ui/BlinkIdFeedbackUi.tsxpackages/blinkid-verify-core/CHANGELOG.mdpackages/blinkid-verify-core/docs/type-aliases/PingSdkInitStart.mdpackages/blinkid-verify-core/docs/type-aliases/PingUxEvent.mdpackages/blinkid-verify-core/docs/type-aliases/ScanningSettings.mdpackages/blinkid-verify-core/package.jsonpackages/blinkid-verify-ux-manager/CHANGELOG.mdpackages/blinkid-verify-ux-manager/package.jsonpackages/blinkid-verify-ux-manager/src/ui/BlinkIdVerifyFeedbackUi.tsxpackages/blinkid-verify-wasm/CHANGELOG.mdpackages/blinkid-verify-wasm/docs/type-aliases/ScanningSettings.mdpackages/blinkid-verify-wasm/package.jsonpackages/blinkid-verify-wasm/src/Session/scanning-settings.tspackages/blinkid-verify-worker/CHANGELOG.mdpackages/blinkid-verify-worker/package.jsonpackages/blinkid-verify-worker/src/BlinkIdVerifyWorker.tspackages/blinkid-verify/CHANGELOG.mdpackages/blinkid-verify/docs/functions/createBlinkIdVerify.mdpackages/blinkid-verify/docs/type-aliases/PingSdkInitStart.mdpackages/blinkid-verify/docs/type-aliases/PingUxEvent.mdpackages/blinkid-verify/docs/type-aliases/ScanningSettings.mdpackages/blinkid-verify/package.jsonpackages/blinkid-wasm/CHANGELOG.mdpackages/blinkid-wasm/package.jsonpackages/blinkid-worker/CHANGELOG.mdpackages/blinkid-worker/package.jsonpackages/blinkid-worker/src/BlinkIdWorker.test.tspackages/blinkid-worker/src/BlinkIdWorker.tspackages/blinkid/CHANGELOG.mdpackages/blinkid/docs/type-aliases/PingSdkInitStart.mdpackages/blinkid/docs/type-aliases/PingUxEvent.mdpackages/blinkid/package.jsonpackages/ux-common/CHANGELOG.mdpackages/ux-common/package.json
| This report includes: | ||
| - **NPM Dependencies**: Production dependencies from all packages in the monorepo (126 packages) | ||
| - **C++ Dependencies**: Native dependencies for WebAssembly builds (0 unique packages across 0 build flavors) | ||
| - **C++ Dependencies**: Native dependencies for WebAssembly builds (33 unique packages across 1 build flavors) |
There was a problem hiding this comment.
Fix singular/plural wording in the summary.
Line 9 should read “across 1 build flavor” (not “1 build flavors”).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/blinkid-verify/OssDependencies.md` at line 9, Update the summary
sentence that currently reads "**C++ Dependencies**: Native dependencies for
WebAssembly builds (33 unique packages across 1 build flavors)" to use the
singular form "build flavor" instead of "build flavors" so it reads "(33 unique
packages across 1 build flavor)"; locate this exact string in the docs and
correct the wording.
Comment on lines
+146
to
+178
| | abseil/20250512.0.1@microblink/main#120e2c1b766e76087248ee491d67cb52 | Apache-2.0 | [Link](https://github.com/microblink/abseil-cpp) | Abseil Common Libraries (C++) from Google | | ||
| | adv_obfuscator/20170904.1@microblink/main#aa4c2ce54111773ef9ce027667b68d71 | https://github.com/microblink/ADVobfuscator#copyright-and-license | [Link](https://github.com/microblink/ADVobfuscator) | Obfuscation library based on C++11/14 and metaprogramming | | ||
| | boost/1.84.1@microblink/main#bff79afef94bda2190fd38c952381df6 | Boost Software license | [Link](https://bitbucket.org/microblink/boost) | Free peer-reviewed portable C++ source libraries. | | ||
| | concurrent_queue/1.0.1@microblink/main#b452679c066c30530f176c59cd276208 | Dual licensed under Simplified BSD License and Boost Software License - Version 1.0 | [Link](https://github.com/microblink/concurrentqueue) | A fast multi-producer, multi-consumer lock-free concurrent queue for C++11 | | ||
| | config_ex/1.1.1@microblink/main#58895a244f6055c6017a95e43ef5ce63 | MIT | [Link](https://github.com/microblink/config_ex) | Additions to boost/config for additional compiler-specific codegen tweaking macros | | ||
| | cpuinfo/20250509.9@microblink/main#40de5b1b7859404e36455d2a5a670efb | BSD 2-Clause "Simplified" License | [Link](https://github.com/microblink/cpuinfo) | cpuinfo is a library to detect essential for performance optimization information about host CPU | | ||
| | eigen/3.4.2@microblink/main#406195518d246c1d387b54df8ade9052 | Mozilla Public License Version 2.0 | [Link](https://github.com/microblink/eigen-git-mirror) | Eigen is a C++ template library for linear algebra: vectors, matrices, and related algorithms. It is versatile, fast, elegant and works on many platforms (OS/Compilers). | | ||
| | err/1.0.2@microblink/main#c37bea8eb2a49b4f46fdd47f028d144d | Boost Software License | [Link](https://github.com/microblink/err) | err - yet another take on C++ error handling | | ||
| | functionoid/1.0.1@microblink/main#a63c389de8e94c11f18c62430bb3aa1f | Boost Software License, Version 1.0 | [Link](https://github.com/microblink/functionoid) | a complete C++17 rewrite of boost/std::function | | ||
| | gtest/1.14.10@microblink/main#aeea6cc884a4400edf8084592f7b23ec | BSD 3-Clause | [Link](https://bitbucket.org/microblink/core-google-test/src) | Google's C++ test framework | | ||
| | hash/2.0.3@microblink/main#bca5158cdd3532fd9a32d7539b66194f | zlib | [Link](https://github.com/microblink/hash-library) | Portable C++ Hashing Library | | ||
| | kiwaku/20230809.4@microblink/main#6e5eb5cb85661173d4d516738282e5db | BSL-1.0 | [Link](https://github.com/microblink/kiwaku) | C++20 and onward collection of high performance data containers and related tools | | ||
| | libjpeg_turbo/3.0.2.2@microblink/main#c5ae8c1d15ab8215718ea3df429e55e1 | BSD-3-Clause, Zlib | [Link](https://github.com/microblink/libjpeg-turbo) | SIMD-accelerated libjpeg-compatible JPEG codec library | | ||
| | libpng/1.6.48@microblink/main#a894c6d32b60eb517232069228102b95 | libpng-2.0 | [Link](https://github.com/microblink/libpng) | An Open, Extensible Image Format with Lossless Compression | | ||
| | micro_ecc/1.0.0@microblink/main#1c323460f6536c0b0f5baaed9de6bcf5 | BSD 2-Clause "Simplified" License | [Link](https://github.com/microblink/micro-ecc) | A small and fast ECDH and ECDSA implementation for 8-bit, 32-bit, and 64-bit processors. | | ||
| | mmap/1.0.2@microblink/main#49540e8a3d87662b601b9b433396582c | Boost Software License | [Link](https://github.com/microblink/mmap) | portable, lightweight, powerful, near-zero-overhead memory mapping and virtual memory management | | ||
| | nlohmann_json/3.10.4#2d3ba0c641692cca9fb4514e05154688 | MIT | [Link](https://github.com/conan-io/conan-center-index) | JSON for Modern C++ parser and generator. | | ||
| | opencv/4.10.1@microblink/main#2bc2be2ecc71966cde69f7dbdf85a312 | MIT | [Link](https://github.com/microblink/opencv) | Microblink's fork of OpenCV | | ||
| | pimpl/1.0.1@microblink/main#4857170a202027c0fd2f22d0c2c4c7a3 | BSD 2-Clause "Simplified" License | [Link](https://github.com/microblink/pimpl) | Proving pimpls do not require heap, exceptions or runtime polymorphism. | | ||
| | protobuf/4.25.2@microblink/main#732767a0c74df7e4d7955a035060b19d | BSD | [Link](https://github.com/microblink/protobuf) | Google's language-neutral, platform-neutral, extensible mechanism for serializing structured data | | ||
| | qoixx/0.1.7.3@microblink/main#7a99513f8b969271ba87111c1317f1f0 | MIT License | [Link](https://github.com/microblink/qoixx) | qoixx is a high performance MIT licensed single-header QOI implementation written in C++20. | | ||
| | range-v3/0.12.0#abb9932b80d96eaf8fc992debe3870ed | BSL-1.0 | [Link](https://github.com/conan-io/conan-center-index) | Experimental range library for C++11/14/17 | | ||
| | rapidjson/1.1.6@microblink/main#22545451e78c6dfb8c85f2e14b862674 | BSD | [Link](https://bitbucket.org/microblink/core-rapidjson) | A fast JSON parser/generator for C++ with both SAX/DOM style API | | ||
| | re2/20240702.0.0@microblink/main#97effdb903f6546348047925d9d1f365 | BSD-3-Clause | [Link](https://github.com/microblink/re2) | Fast, safe, thread-friendly regular expression library | | ||
| | std_fix/1.0.2@microblink/main#3002fa1150d5261ad74d2d167d48e653 | BSL-1.0 | [Link](https://github.com/microblink/std_fix) | Patches for deficient C++ runtime implementations | | ||
| | sweater/1.1.7@microblink/main#00226324984e8fb052dd8e703b48d28e | MIT | [Link](https://github.com/microblink/sweater) | Humble Outer Dispatch | | ||
| | tf_messages/1.0.1@microblink/main#96187cc0ac393ee835b807074bb3e884 | Apache License 2.0 | [Link](https://bitbucket.org/microblink/core-tensorflow/) | Computation using data flow graphs for scalable machine learning | | ||
| | tinyxml2/2.2.4@microblink/main#e75d39f68113ec40fde0b991ffa76a37 | Zlib | [Link](https://github.com/microblink/tinyxml2) | a simple, small, efficient, C++ XML parser | | ||
| | tqdm/1.0.0@microblink/main#9f84ad8bec3a73f9635d64c0f49aea96 | MIT | [Link](https://bitbucket.org/microblink/core-tqdm) | tqdm-like single header c++ pretty progress bar | | ||
| | utfcpp/4.0.6@microblink/main#ea11de5465f5305ad0fc5d691185d7a5 | Boost Software License 1.0 | [Link](https://github.com/microblink/utfcpp) | UTF-8 with C++ in a Portable Way | | ||
| | xnnpack/20230525.1.6@microblink/main#3e5e60789c103ebfec170c7898cdfe4d | BSD | [Link](https://github.com/microblink/XNNPACK) | XNNPACK library | | ||
| | zlib/1.3.2@microblink/main#52419110a760a9cb8cd7bd57b01de0b2 | Zlib | [Link](https://github.com/microblink/zlib) | A massively spiffy yet delicately unobtrusive compression library. | | ||
| | zxing-cpp/1.1.0@microblink/main#6650d1dcd9e84e7917697e701c82ad47 | Apache License 2.0 | [Link](https://github.com/microblink/zxing) | ZXing ("Zebra Crossing") barcode scanning library for Java, Android | |
There was a problem hiding this comment.
Use descriptive link text instead of repeated Link.
Lines 146–178 reduce readability/accessibility and trigger markdownlint MD059. Prefer package-specific labels (for example, repository names) in the URL column.
Suggested diff
-| abseil/... | Apache-2.0 | [Link](https://github.com/microblink/abseil-cpp) | ...
+| abseil/... | Apache-2.0 | [abseil-cpp](https://github.com/microblink/abseil-cpp) | ...🧰 Tools
🪛 LanguageTool
[uncategorized] ~157-~157: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...iwaku) | C++20 and onward collection of high performance data containers and related tools | | l...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[grammar] ~166-~166: Use a hyphen to join words.
Context: ....com/microblink/qoixx) | qoixx is a high performance MIT licensed single-header Q...
(QB_NEW_EN_HYPHEN)
[grammar] ~166-~166: Use a hyphen to join words.
Context: ...qoixx) | qoixx is a high performance MIT licensed single-header QOI implementatio...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.22.0)
[warning] 146-146: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 147-147: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 148-148: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 149-149: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 150-150: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 151-151: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 152-152: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 153-153: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 154-154: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 155-155: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 156-156: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 157-157: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 158-158: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 159-159: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 160-160: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 161-161: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 162-162: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 163-163: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 164-164: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 165-165: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 166-166: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 167-167: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 168-168: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 169-169: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 170-170: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 171-171: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 172-172: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 173-173: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 174-174: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 175-175: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 176-176: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 177-177: Link text should be descriptive
(MD059, descriptive-link-text)
[warning] 178-178: Link text should be descriptive
(MD059, descriptive-link-text)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/blinkid-verify/OssDependencies.md` around lines 146 - 178, The table
rows currently use identical link text "[Link](...)" (e.g., entries like
abseil/20250512.0.1@microblink/main#120e2c1b766e76087248ee491d67cb52,
adv_obfuscator/20170904.1@microblink/main#aa4c2ce...,
boost/1.84.1@microblink/main#bff79afe..., etc.), which triggers markdownlint
MD059; update each markdown link label in OssDependencies.md to a descriptive,
package- or repository-specific text (for example use "abseil-cpp",
"ADVobfuscator", "boost", "concurrentqueue", "config_ex", etc.) instead of the
generic "Link" so each row's URL column is unique and accessible while
preserving the existing URLs.
Comment on lines
+5
to
+11
| ### Patch Changes | ||
|
|
||
| - Updated analytics package | ||
| - Updated dependencies | ||
| - @microblink/analytics@2.0.0 | ||
| - @microblink/blinkcard-worker@3000.0.5 | ||
| - @microblink/blinkcard-wasm@3000.0.5 |
There was a problem hiding this comment.
Patch release likely masks a breaking API surface change.
@microblink/analytics was bumped to 2.0.0, and @microblink/blinkcard-core re-exports analytics types/services (packages/blinkcard-core/src/index.ts, Lines 15-19). This can introduce consumer-facing breakage, so classifying 3000.0.5 as patch is risky.
Please re-check semver impact and release type (and matching package version) for @microblink/blinkcard-core.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/blinkcard-core/CHANGELOG.md` around lines 5 - 11, The changelog
labels the release as a patch while `@microblink/analytics` was bumped to 2.0.0
and blinkcard-core re-exports analytics types/services (see
packages/blinkcard-core/src/index.ts where analytics types/services are
re-exported), which likely introduces a breaking change; update the release
classification and versioning: re-evaluate semver impact, change CHANGELOG.md
and the package.json version for `@microblink/blinkcard-core` from patch to a
compatible major/minor release (or pin the analytics dependency to a
non-breaking version), and ensure the release notes explicitly document the
breaking API (or revert the re-export) so consumers are not surprised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
scanPassportDataPageOnlyandscanUnsupportedBackfor enhanced document processing control.Documentation
Chores