GP - Post migration validation feature #29395
Conversation
|
Issue #579005 is not valid. Please make sure you link an issue that exists, is open and is approved. |
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/US/HybridGP_US/app/src/Codeunits/GPUSMigrationValidator.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/CompanyMigrationStatus.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/CompanyMigrationStatus.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/HybridBaseDeployment/app/src/pages/IntelligentCloudStatFactbox.Page.al
Show resolved
Hide resolved
…Product Type lookup. Updated Codeunit Id.
Apps/W1/HybridBaseDeployment/app/src/codeunits/HybridCloudManagement.Codeunit.al
Show resolved
Hide resolved
| if not MigrationValidationError.IsEmpty() then | ||
| MigrationValidationError.DeleteAll(); | ||
|
|
||
| CompanyValidationProgress.SetRange("Company Name", CompanyName()); |
There was a problem hiding this comment.
Maybe we could save a table and add addtional fields to hybrid company status?
Apps/W1/HybridBaseDeployment/app/src/tables/MigrationValidationBuffer.Table.al
Show resolved
Hide resolved
| @@ -0,0 +1,111 @@ | |||
| namespace Microsoft.DataMigration; | |||
|
|
|||
| table 40046 "Migration Validation Buffer" | |||
There was a problem hiding this comment.
This table is not the best approach. We need a different approach to store the data that needs to be validated.
| @@ -0,0 +1,60 @@ | |||
| namespace Microsoft.DataMigration; | |||
|
|
|||
| codeunit 40031 "Migration Validator Warning" implements "Cloud Migration Warning" | |||
There was a problem hiding this comment.
We already have warnings system, it would be good to align the 2 existing systems.
There was a problem hiding this comment.
This is in the base. I wanted to align with the Cloud Migration Warning feature there. I think eventually the GP warnings will move toward this new approach.
|
|
||
| repeat | ||
| Commit(); | ||
| if not Codeunit.Run(MigrationValidatorRegistry."Codeunit Id") then begin |
There was a problem hiding this comment.
We have talked about continuation.
GP may not need it, however the other products will most likely need the continuation. This is a generic codeunit that can be used by other migrations. We need to remember which tests were done and have a way to continue where we stopped.
| @@ -0,0 +1,97 @@ | |||
| namespace Microsoft.DataMigration; | |||
|
|
|||
| page 40066 "Company Migration Status" | |||
There was a problem hiding this comment.
We have existing pages that are showing the status, can't we reuse any of them?
| { | ||
| Caption = 'Validation Step'; | ||
| } | ||
| } |
There was a problem hiding this comment.
We also need the status on the validator, so the checks can continue if interrupted.
The table is generic so it would be really good to get the support for this
Apps/W1/HybridBaseDeployment/test/src/DummyMigrationValidator.Codeunit.al
Show resolved
Hide resolved
4 participants
Fixes #579005