This repository was archived by the owner on Aug 21, 2025. It is now read-only.
Potential fix for code scanning alert no. 13: Double escaping or unescaping #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caping Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/microsoft/AcademicContent/security/code-scanning/13
To fix the double-unescaping problem, the order of replacements in the
unescapefunction should be changed so that the ampersand (&) is unescaped last. This ensures that any other entities (like",', etc.) are unescaped before the ampersand, preventing the accidental creation of new entities that would then be unescaped again. The fix involves moving the.replace(/&/g, '&')call to the end of the chain in theunescapefunction. No new imports or dependencies are needed, and the change is limited to theunescapemethod in the shown file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.