Clean up graph code #5657
Merged
Clean up graph code #5657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
previously approved these changes
Dec 17, 2025
compulim
requested review from
a-b-r-o-w-n,
beyackle2,
cwhitten,
srinaath and
tdurnford
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a cleanup of the graph code following the introduction of the new JSON-LD graph backend in PR #5622. The main purpose is to rename Graph2 back to Graph and improve the structure of the useActivities() hook for better code organization and maintainability.
- Renamed
Graph2class and all its imports back toGraph - Refactored
useActivities()hook to separate production and development implementations - Updated TODO comment to include priority marker and more specific iOS version reference
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core-graph/src/private/Graph.ts | Renamed Graph2 class to Graph and updated TODO comment with priority and version details |
| packages/core-graph/src/index.ts | Updated export path from Graph2 to Graph |
| packages/core-graph/src/private/SlantGraph/SlantGraph.ts | Updated import path from Graph2 to Graph |
| packages/core-graph/src/private/SlantGraph/private/*.ts | Updated import paths in terminator.ts, color.ts, autoInversion.ts, and assertSlantNode.ts from Graph2 to Graph |
| packages/core-graph/src/private/*.spec.ts | Updated test file imports from Graph2 to Graph in all spec files |
| packages/api/src/hooks/useActivities.ts | Refactored to separate useActivitiesForProduction and useActivitiesForDevelopment functions for clearer code organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
OEvgeny
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
Clean up some code after #5622.
Design
Specific Changes
Graph2back toGraphuseActivities()hookI have added tests and executed them locallyCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)