Skip to content

allow final action to invoke throwing actions #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
apenn-msft wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

allow final action to invoke throwing actions #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ffd430
allow final action to invoke throwing actions
apenn-msft Feb 3, 2025
628b2c5
Update headers.md
apenn-msft Feb 3, 2025
e00c1cc
fix syntax
apenn-msft Feb 3, 2025
49371c5
syntax fix
apenn-msft Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/headers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ explicit final_action(F&& ff) noexcept;
Construct an object with the action to invoke in the destructor.

```cpp
~final_action() noexcept;
~final_action() noexcept(std::is_nothrow_invocable_v<F>);
```

The destructor will call the action that was passed in the constructor.
Expand Down
2 changes: 1 addition & 1 deletion include/gsl/util
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public:
explicit final_action(const F& ff) noexcept : f{ff} { }
explicit final_action(F&& ff) noexcept : f{std::move(ff)} { }

~final_action() noexcept { if (invoke) f(); }
~final_action() noexcept(std::is_nothrow_invocable_v<F>) { if (invoke) f(); }

final_action(final_action&& other) noexcept
: f(std::move(other.f)), invoke(std::exchange(other.invoke, false))
Expand Down
Loading