Add Brave Browser keyboard shortcuts manifest for Shortcut Guide - #49615
Add Brave Browser keyboard shortcuts manifest for Shortcut Guide#49615Niels Laute (niels9001) with Copilot wants to merge 4 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Adds a new Shortcut Guide manifest so Brave Browser windows can show app-specific keyboard shortcuts when Brave is the active window.
Changes:
- Add
BraveSoftware.BraveBrowser.en-US.ymlmanifest with sections covering tab/window management, Brave features, address bar, and web page actions.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Copilot The correct package name is Brave.Brave |
Done — renamed the file to |
| Ctrl: true | ||
| Shift: false |
There was a problem hiding this comment.
Severity: high
Brave uses Alt+Shift+N for a Tor private window, so the current manifest teaches a shortcut that the browser will not honor. Swapping the Ctrl and Shift flags here makes Shortcut Guide surface the actual accelerator.
| Ctrl: true | |
| Shift: false | |
| Ctrl: false | |
| Shift: true |
| Shift: false | ||
| Alt: false | ||
| Keys: | ||
| - "<1>" |
There was a problem hiding this comment.
Severity: medium
This command jumps to any of the first eight tabs, but the current manifest serializes it as only Ctrl+1. Using the free-form 1 - 8 token keeps Shortcut Guide from collapsing the label down to a single digit.
| - "<1>" | |
| - 1 - 8 |
Shortcut Guide had no manifest for Brave Browser, so no shortcuts were displayed when Brave was the active window.
Summary of the Pull Request
Adds
BraveSoftware.BraveBrowser.en-US.ymlto the Shortcut Guide manifests directory. UsesWindowFilter: "brave.exe"to match the active process. The index is auto-generated at runtime by enumerating all.ymlfiles, so no code changes are required.PR Checklist
Detailed Description of the Pull Request / Additional comments
57 shortcuts across 4 sections, mirroring the Chrome manifest structure (Brave is Chromium-based) with Brave-specific adjustments:
Ctrl+Alt+N)Alt+D), bookmarks bar, history, downloads, DevTools, task manager, find bar, clear browsing dataValidation Steps Performed
WindowFilter: "brave.exe"matches the Brave Browser executable name.ymlfiles — no index update needed