Skip to content

Add Brave Browser keyboard shortcuts manifest for Shortcut Guide - #49615

Open
Niels Laute (niels9001) with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-shortcut-guide-brave-browser
Open

Add Brave Browser keyboard shortcuts manifest for Shortcut Guide#49615
Niels Laute (niels9001) with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-shortcut-guide-brave-browser

Conversation

Copilot AI commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Shortcut Guide had no manifest for Brave Browser, so no shortcuts were displayed when Brave was the active window.

Summary of the Pull Request

Adds BraveSoftware.BraveBrowser.en-US.yml to the Shortcut Guide manifests directory. Uses WindowFilter: "brave.exe" to match the active process. The index is auto-generated at runtime by enumerating all .yml files, so no code changes are required.

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

57 shortcuts across 4 sections, mirroring the Chrome manifest structure (Brave is Chromium-based) with Brave-specific adjustments:

  • Tabs and windows — standard tab/window management plus Brave's unique "New private window with Tor" (Ctrl+Alt+N)
  • Brave features — Brave Shields toggle (Alt+D), bookmarks bar, history, downloads, DevTools, task manager, find bar, clear browsing data
  • Address bar — navigation and search shortcuts
  • Web page — print, save, reload, zoom, bookmarking, page source, scrolling

Validation Steps Performed

  • YAML parsed and validated programmatically; structure matches the existing manifest schema
  • Confirmed WindowFilter: "brave.exe" matches the Brave Browser executable name
  • Confirmed index.yml is generated at runtime from all .yml files — no index update needed

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI changed the title [WIP] Fix Shortcut Guide missing Brave Browser shortcuts Add Brave Browser keyboard shortcuts manifest for Shortcut Guide Aug 1, 2026
@niels9001
Niels Laute (niels9001) marked this pull request as ready for review August 2, 2026 07:58
@niels9001
Niels Laute (niels9001) enabled auto-merge (squash) August 2, 2026 07:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Shortcut Guide manifest so Brave Browser windows can show app-specific keyboard shortcuts when Brave is the active window.

Changes:

  • Add BraveSoftware.BraveBrowser.en-US.yml manifest with sections covering tab/window management, Brave features, address bar, and web page actions.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@noraa-junker

Copy link
Copy Markdown
Collaborator

Copilot The correct package name is Brave.Brave

Copilot AI commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

Copilot The correct package name is Brave.Brave

Done — renamed the file to Brave.Brave.en-US.yml and updated PackageName to Brave.Brave in commit Rename Brave manifest to use correct WinGet package ID Brave.Brave.

Comment on lines +29 to +30
Ctrl: true
Shift: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: high
Brave uses Alt+Shift+N for a Tor private window, so the current manifest teaches a shortcut that the browser will not honor. Swapping the Ctrl and Shift flags here makes Shortcut Guide surface the actual accelerator.

Suggested change
Ctrl: true
Shift: false
Ctrl: false
Shift: true

Shift: false
Alt: false
Keys:
- "<1>"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: medium
This command jumps to any of the first eight tabs, but the current manifest serializes it as only Ctrl+1. Using the free-form 1 - 8 token keeps Shortcut Guide from collapsing the label down to a single digit.

Suggested change
- "<1>"
- 1 - 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortchut Guide missing Brave Browser

5 participants