-
Notifications
You must be signed in to change notification settings - Fork 459
Migrate ValueTypeMap & MemoryDescriptor #2232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,17 @@ | ||
| enum ImportExportKind legacyNamespace=WebAssembly | ||
| enum TableKind legacyNamespace=WebAssembly | ||
| enum AddressType legacyNamespace=WebAssembly | ||
|
|
||
| dictionary ValueTypeMap legacyNamespace=WebAssembly exposed="Window Worker Worklet" { | ||
| member anyfunc required=#true type=Function | ||
| member externref required=#true type=any | ||
| member f32 required=#true type=long | ||
| member f64 required=#true type=long | ||
| member i32 required=#true type=long | ||
| member i64 required=#true type=bigint | ||
| member v128 required=#true overrideType=never | ||
| } | ||
|
|
||
| dictionary MemoryDescriptor { | ||
| member shared type=boolean | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -298,6 +298,12 @@ function handleDictionary(child: Node): DeepPartial<Dictionary> { | |
| return { | ||
| name, | ||
| members: { member }, | ||
| ...optionalMember("extends", "string", child.properties?.extends), | ||
|
||
| ...optionalMember( | ||
| "legacyNamespace", | ||
| "string", | ||
| child.properties?.legacyNamespace, | ||
| ), | ||
| }; | ||
| } | ||
|
|
||
|
|
@@ -311,6 +317,7 @@ function handleMember(c: Node): Partial<Member> { | |
| name, | ||
| ...optionalMember("type", "string", c.properties?.type), | ||
| ...optionalMember("required", "boolean", c.properties?.required), | ||
| ...optionalMember("overrideType", "string", c.properties?.overrideType), | ||
| }; | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are at it, let's remove
exposedhere. Dictionaries do not need it and I missed it in #963.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done