Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 0 additions & 54 deletions inputfiles/addedTypes.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -842,16 +842,6 @@
}
}
},
"MemoryDescriptor": {
"members": {
"member": {
"shared": {
"name": "shared",
"type": "boolean"
}
}
}
},
"ReadableStreamReadDoneResult": {
"name": "ReadableStreamReadDoneResult",
"typeParameters": [
Expand Down Expand Up @@ -952,50 +942,6 @@
}
}
}
},
"ValueTypeMap": {
"name": "ValueTypeMap",
"legacyNamespace": "WebAssembly",
"exposed":"Window Worker Worklet",
"members": {
"member": {
"anyfunc": {
"name": "anyfunc",
"overrideType": "Function",
"required": 1
},
"externref": {
"name": "externref",
"overrideType": "any",
"required": 1
},
"f32": {
"name": "f32",
"overrideType": "number",
"required": 1
},
"f64": {
"name": "f64",
"overrideType": "number",
"required": 1
},
"i32": {
"name": "i32",
"overrideType": "number",
"required": 1
},
"i64": {
"name": "i64",
"overrideType": "bigint",
"required": 1
},
"v128": {
"name": "v128",
"overrideType": "never",
"required": 1
}
}
}
}
}
},
Expand Down
14 changes: 14 additions & 0 deletions inputfiles/patches/webassembly.kdl
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
enum ImportExportKind legacyNamespace=WebAssembly
enum TableKind legacyNamespace=WebAssembly
enum AddressType legacyNamespace=WebAssembly

dictionary ValueTypeMap legacyNamespace=WebAssembly exposed="Window Worker Worklet" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, let's remove exposed here. Dictionaries do not need it and I missed it in #963.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

member anyfunc required=#true type=Function
member externref required=#true type=any
member f32 required=#true type=long
member f64 required=#true type=long
member i32 required=#true type=long
member i64 required=#true type=bigint
member v128 required=#true overrideType=never
}

dictionary MemoryDescriptor {
member shared type=boolean
}
17 changes: 4 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/build/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const sameTypes = new Set([
"PromiseLike",
"undefined",
"void",
"bigint",
]);
export const baseTypeConversionMap = new Map<string, string>([
...[...bufferSourceTypes].map((type) => [type, type] as const),
Expand Down
7 changes: 7 additions & 0 deletions src/build/patches.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,12 @@ function handleDictionary(child: Node): DeepPartial<Dictionary> {
return {
name,
members: { member },
...optionalMember("extends", "string", child.properties?.extends),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be skipped for now, as we are not using "extends" here. You might have intended to do "exposed" but...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fixed it

...optionalMember(
"legacyNamespace",
"string",
child.properties?.legacyNamespace,
),
};
}

Expand All @@ -311,6 +317,7 @@ function handleMember(c: Node): Partial<Member> {
name,
...optionalMember("type", "string", c.properties?.type),
...optionalMember("required", "boolean", c.properties?.required),
...optionalMember("overrideType", "string", c.properties?.overrideType),
};
}

Expand Down