Fix __setFunctionName overriding custom static name property#62902
Open
pranshugupta01 wants to merge 5 commits intomicrosoft:mainfrom
Open
Fix __setFunctionName overriding custom static name property#62902pranshugupta01 wants to merge 5 commits intomicrosoft:mainfrom
pranshugupta01 wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
Hi @RyanCavanaugh , please review this PR , thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #62854 where the __setFunctionName helper unconditionally overwrites custom static name properties (getters, methods, accessors) on decorated classes.
The Problem
The error occurred because __setFunctionName used Object.defineProperty to unconditionally set the name property, ignoring any custom static name getter, method, or accessor defined by the user.
The Fix:
Modified the __setFunctionName helper in src/compiler/factory/emitHelpers.ts to check the existing property descriptor before overwriting:
Testing
Baseline Changes
New baselines:
All 99,167 tests pass.