[moved] Add X25519 generateKey overload to SubtleCrypto#62961
Closed
kairosci wants to merge 1 commit intomicrosoft:mainfrom
Closed
[moved] Add X25519 generateKey overload to SubtleCrypto#62961kairosci wants to merge 1 commit intomicrosoft:mainfrom
kairosci wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This adds a specific overload for the X25519 key exchange algorithm following the same pattern as the existing Ed25519 overload. X25519 is used for key derivation (ECDH), so it uses 'deriveBits' and 'deriveKey' as valid keyUsages, unlike Ed25519 which uses 'sign' and 'verify'. This allows TypeScript to correctly infer CryptoKeyPair as the return type when using X25519, eliminating the need for type assertions. Fixes microsoft#62926
Collaborator
|
It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TypeScript-DOM-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed. |
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a specific overload for the X25519 key exchange algorithm to the
SubtleCrypto.generateKey()method, following the same pattern as the existing Ed25519 overload.Changes
Added the following overload to
SubtleCryptointerface in bothdom.generated.d.tsandwebworker.generated.d.ts:Rationale
X25519 is used for key derivation (ECDH), so it uses
deriveBitsandderiveKeyas valid keyUsages, unlike Ed25519 which usessignandverify.This allows TypeScript to correctly infer
CryptoKeyPairas the return type when using X25519, eliminating the need for type assertions or instanceof checks: