fix: use firefox in doctor screenshot check#45
Open
nuthalapativarun wants to merge 3 commits into
Open
Conversation
New users have no way to discover which config files are available without browsing the source tree. Add `python -m webwright.run.cli list-configs` that prints all .yaml filenames from the built-in config directory. Update the README flags table to document the new command.
…tion Registering a second @app.command() forced Typer to require an explicit subcommand, breaking the existing `python -m webwright.run.cli -t "..."` invocation form. Switch `main` to @app.callback(invoke_without_command=True) so the default invocation works without a subcommand while list-configs remains available as an explicit subcommand. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SKILL.md and local_browser.yaml specify Firefox as the required browser, but check_screenshot launched Chromium. Users who followed the quickstart and only installed Firefox got a false FAIL on the screenshot check. - p.chromium.launch() -> p.firefox.launch() - Renamed check_chromium to check_firefox; updated messages/hints to reference Firefox - Updated CHECKS registry entry label from Chromium to Firefox - Updated test_doctor.py to import and call check_firefox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doctorscreenshot check now launches Firefox instead of Chromiumplaywright install firefoxcheck_chromiumrenamed tocheck_firefoxwith updated messages throughouttests/unit/test_doctor.pyupdated to import and callcheck_firefoxWhy
SKILL.mdandlocal_browser.yamlboth specify Firefox as the required browser, butcheck_screenshotlaunched Chromium. Users who followed the quickstart and only installed Firefox got a false FAIL on the screenshot check.Changes
src/webwright/run/doctor.pyline ~54:p.chromium.launch()→p.firefox.launch(); updated failure hint string; renamedcheck_chromium→check_firefox; updated CHECKS registry labeltests/unit/test_doctor.py: updated import and test function name fromcheck_chromiumtocheck_firefoxTesting