fix: remove stale workspace-mode prompts from persistent_browser.yaml#46
Open
nuthalapativarun wants to merge 1 commit into
Open
Conversation
- Replace bare `final_script.py` reference in Helpful Command Patterns with the correct run-folder path `final_runs/run_<id>/final_script.py` - Replace hardcoded `final_runs/run_003/` image_qa examples with generic `run_<id>` placeholders - Replace oversimplified done-gate constraint (\"final_script.py is the final artifact\") with a summary that points to the full Completion Gate - Add summary_user_prompt override to reference judge_config.json instead of the default self_reflect_config.json from base.yaml Follow-up to microsoft#16 which noted the same copy-pasted issues in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
final_script.pyreference in Helpful Command Patterns with the correct run-folder pathfinal_runs/run_<id>/final_script.pyfinal_runs/run_003/paths inimage_qaexamples with genericrun_<id>placeholdersself_reflectionand Chromium-release requirementssummary_user_promptoverride referencingjudge_config.jsoninstead of the defaultself_reflect_config.jsoninherited frombase.yamlWhy
PR #16 fixed
local_browser.yamland called out thatpersistent_browser.yamlhad the same copy-pasted workspace-mode prompts that don't accurately reflect the execution model. Specifically:final_script.pyinspect pattern implied the script lives at the workspace root, but in this mode it lives underfinal_runs/run_<id>/image_qaexamples had hardcodedrun_003paths, making them misleading for other run IDsfinal_script.pyas the final artifact, omitting the requiredself_reflectionpass and Chromium release stepssummary_user_promptreferencesself_reflect_config.jsonbut this mode usesjudge_config.jsonChanges
src/webwright/config/persistent_browser.yaml: prompt cleanup as described aboveTesting