Skip to content

.NET: Improve observability sample#4917

Merged
TaoChenOSU merged 2 commits intomainfrom
taochen/dotnet-improve-observability-sample
Mar 26, 2026
Merged

.NET: Improve observability sample#4917
TaoChenOSU merged 2 commits intomainfrom
taochen/dotnet-improve-observability-sample

Conversation

@TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented Mar 25, 2026

Motivation and Context

Update the Agent Observability sample .Net based on feedback from office hour.

Description

  1. Remove confusing source name from AddSource() as it's not necessary.
  2. Doc update follows in the doc repo.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

@TaoChenOSU TaoChenOSU self-assigned this Mar 25, 2026
@TaoChenOSU TaoChenOSU added .NET observability Issues related to observability or telemetry labels Mar 25, 2026
@TaoChenOSU TaoChenOSU moved this to In Review in Agent Framework Mar 25, 2026
@github-actions github-actions bot changed the title Improve observability sample .NET: Improve observability sample Mar 25, 2026
@TaoChenOSU TaoChenOSU marked this pull request as ready for review March 26, 2026 03:57
Copilot AI review requested due to automatic review settings March 26, 2026 03:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the .NET AgentOpenTelemetry sample to simplify OpenTelemetry configuration and reduce confusion around instrument/source registration.

Changes:

  • Removed wildcard AddSource / AddMeter registrations intended for Agent Framework telemetry.
  • Tweaked the sample’s SourceName documentation and clarified UseOpenTelemetry usage with a named argument.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@TaoChenOSU TaoChenOSU enabled auto-merge March 26, 2026 17:21
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit 63dee91 Mar 26, 2026
21 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Agent Framework Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET observability Issues related to observability or telemetry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants