Emit events when modules fail to load silently#7
Open
gszep wants to merge 1 commit intomicrosoft:mainfrom
Open
Emit events when modules fail to load silently#7gszep wants to merge 1 commit intomicrosoft:mainfrom
gszep wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Emit module:load_error event when providers, tools, or hooks fail to load (e.g., missing dependency). Previously these failures were silently swallowed with only a log warning, making debugging difficult. Event payload includes module_id, module_type (provider|tool|hook), and error message. Failures now appear in events.jsonl for observability while maintaining existing graceful degradation behavior.
Author
|
@microsoft-github-policy-service agree [company="Chiba Institute of Technology"] |
Author
|
@microsoft-github-policy-service agree company="Chiba Institute of Technology" |
Author
|
closing as it is not that important - issue does not persist after clean re-install. |
Author
|
re-opening as the following error was raised after today's |
Author
|
issue resolves after clean re-install (without losing session history) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
amplifier updatewhile developing a local module the session started but the module silently failed to load. After an attempted tool call the session raises:This PR emits a
module:load_error eventwhen providers, tools, or hooks fail to load. The event appears inevents.jsonlwith the module ID, type, and actual error message, making failures visible withoutchanging the existing graceful degradation behavior.
Event payload
{"module_id": "my-tool", "module_type": "tool", "error": "No module named 'aiohttp'"}Changes
Follow-up
A separate PR could preserve
ImportError/ModuleNotFoundErrorspecifically inloader.pyrather than catching all exceptions - this would improve diagnostics by keeping the actual error type instead of converting everything to a generic string.