-
Notifications
You must be signed in to change notification settings - Fork 10
docs: Add 'Before Building New Functionality' guidance to AWARENESS_INDEX #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6ca0168 to
ce5225d
Compare
bkrabach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review: PR #55 - "Before Building New Functionality" guidance
The approach here is architecturally sound - adding lightweight guidance to AWARENESS_INDEX is the correct pattern:
- Thin pointer (~100 tokens) in a file that's meant to propagate
- Directs agents to consult an expert rather than loading heavy docs directly
- Preserves the context sink pattern
Issue: Agent Reference Should Be amplifier:amplifier-expert
The PR references amplifier:module-catalog, but this agent doesn't exist. The correct agent is amplifier:amplifier-expert, which already has MODULES.md @mentioned in its body (line 88) and is explicitly designed as the authoritative consultant for ecosystem knowledge.
Required Fix
-| **New module/tool/capability** | **Consult `amplifier:module-catalog`** |
+| **New module/tool/capability** | **Consult `amplifier:amplifier-expert`** |
-1. **Consult `amplifier:module-catalog`** - Focused expert with the complete ecosystem catalog (MODULES.md)
+1. **Consult `amplifier:amplifier-expert`** - Authoritative ecosystem consultant with access to MODULES.mdNote on Companion PR
The companion PR (amplifier#211) has architectural concerns - adding MODULES.md to context.include would propagate it to all parent bundles, defeating the context sink pattern. I've requested changes there.
This PR (#55) takes the right approach. Just needs the agent reference corrected.
Addressing FeedbackThanks Brian! Note:
|
| Agent | Purpose | Token Cost |
|---|---|---|
amplifier-expert |
General ecosystem guidance | ~2k tokens (ecosystem-overview.md) |
module-catalog |
Focused "what exists?" queries | ~4.6k tokens (MODULES.md) - only when spawned |
This follows the context sink pattern more precisely:
- Thin trigger in AWARENESS_INDEX (~30 tokens): "consult module-catalog before building"
- Heavy catalog loads only when that specific agent runs
If we used amplifier-expert instead, users asking general ecosystem questions ("how do I create a bundle?") would also load MODULES.md even when they don't need the catalog.
context.include Issue Fixed
Per your feedback on #211, I removed context.include from the module-catalog behavior. MODULES.md is now loaded only via the @mention in the agent body, so it won't propagate during composition.
Happy to discuss if you'd prefer consolidating into amplifier-expert!
Correction: The Agent Now ExistsApologies for the confusion in my previous comment. When you reviewed, the companion PR (#211) was missing the actual Now fixed: PR #211 has been force-pushed with the complete implementation:
This PR (#55) references Also fixed in #211:
Please re-review both PRs when you have a chance. |
Points to amplifier:module-catalog agent for module discovery. Uses context sink pattern - only loads full catalog when agent spawned. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
ce5225d to
36f8904
Compare
Summary
Add "check before building" guidance to AWARENESS_INDEX.md to prevent module duplication.
Tracking issue: https://github.com/microsoft-amplifier/amplifier-support/issues/43
Changes
context/shared/AWARENESS_INDEX.mdWhat This Adds
Domain Prerequisite Table Entry
"Before Building New Functionality" Section
4-step process:
amplifier:module-catalog-expert- Focused expert with complete ecosystem catalogArchitecture
Related
module-catalog-expertagent)