Set executable permissions at build time instead of runtime#109
Open
Set executable permissions at build time instead of runtime#109
Conversation
Move os.chmod of CredentialProvider.Microsoft binary from plugin.py (runtime) to setup.py (build time). This ensures the binary is already executable when packaged into the wheel, so restricted users who cannot chmod files they don't own no longer encounter permission errors. Fixes #99
cobya
reviewed
Apr 1, 2026
| ) | ||
| if os.path.exists(cred_provider_exe): | ||
| print("Setting executable permissions on", cred_provider_exe) | ||
| os.chmod(cred_provider_exe, 0o755) |
Contributor
There was a problem hiding this comment.
From the issue, we might want to set to 0o777, do you have an opinion here?
Contributor
Author
There was a problem hiding this comment.
I was leaning towards keeping 755. The accounts may differ, but I can't think of a supported scenario where everyone needs write access to the executable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move os.chmod of CredentialProvider.Microsoft binary from plugin.py (runtime) to setup.py (build time). This ensures the binary is already executable when packaged into the wheel, so restricted users who cannot chmod files they don't own no longer encounter permission errors.
Fixes #99