Skip to content

Fix pr-docs safe outputs checkout path#15960

Merged
IEvangelist merged 1 commit intomicrosoft:mainfrom
IEvangelist:dapine/pr-docs-check-safe-outputs-path
Apr 8, 2026
Merged

Fix pr-docs safe outputs checkout path#15960
IEvangelist merged 1 commit intomicrosoft:mainfrom
IEvangelist:dapine/pr-docs-check-safe-outputs-path

Conversation

@IEvangelist
Copy link
Copy Markdown
Member

Description

Follow-up to the pr-docs-check workflow after the v0.67.2 regeneration work.

Root cause

Run https://github.com/microsoft/aspire/actions/runs/24118533263 completed the agent phase and produced the docs changes, but create_pull_request still fell back to an issue-style comment on #15906 (comment).

The safe-outputs handler error was:

Repository 'microsoft/aspire.dev' not found in workspace. Make sure it's checked out using actions/checkout with a path.

So this was no longer a token/permission problem. The generated safe_outputs job was checking out microsoft/aspire.dev at the workspace root, but the cross-repo PR creation handler expects that target repo checkout to live under an explicit path.

What this changes

  • Updates the generated safe_outputs job to check out microsoft/aspire.dev with path: aspire.dev.
  • Runs the git remote configuration from that checkout via working-directory: aspire.dev.

Why this should work

The agent already had access to the docs repo and produced a valid create_pull_request output. This change aligns the follow-up safe-output job with the handler's workspace discovery requirement so it can actually open the draft PR instead of falling back to the explanatory comment.

Update the generated safe_outputs job so cross-repo PR creation checks out microsoft/aspire.dev in a subdirectory path and configures git inside that checkout. This matches the runtime requirement from run 24118533263, where create_pull_request fell back to a comment because the target repository was not found in the workspace.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15960

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15960"

@IEvangelist IEvangelist marked this pull request as ready for review April 8, 2026 13:21
Copilot AI review requested due to automatic review settings April 8, 2026 13:21
@IEvangelist IEvangelist enabled auto-merge (squash) April 8, 2026 13:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the generated pr-docs-check safe-outputs job so the cross-repo PR creation handler can reliably discover the microsoft/aspire.dev checkout in the workflow workspace, avoiding fallback to issue-style comments.

Changes:

  • Check out microsoft/aspire.dev under an explicit path: aspire.dev in the safe_outputs job.
  • Run the git remote/token configuration step from working-directory: aspire.dev.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

@IEvangelist IEvangelist merged commit 836faf0 into microsoft:main Apr 8, 2026
527 of 531 checks passed
IEvangelist added a commit that referenced this pull request Apr 8, 2026
Update the generated safe_outputs job so cross-repo PR creation checks out microsoft/aspire.dev in a subdirectory path and configures git inside that checkout. This matches the runtime requirement from run 24118533263, where create_pull_request fell back to a comment because the target repository was not found in the workspace.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants