Fix pr-docs safe outputs checkout path#15960
Conversation
Update the generated safe_outputs job so cross-repo PR creation checks out microsoft/aspire.dev in a subdirectory path and configures git inside that checkout. This matches the runtime requirement from run 24118533263, where create_pull_request fell back to a comment because the target repository was not found in the workspace. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15960Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15960" |
There was a problem hiding this comment.
Pull request overview
Updates the generated pr-docs-check safe-outputs job so the cross-repo PR creation handler can reliably discover the microsoft/aspire.dev checkout in the workflow workspace, avoiding fallback to issue-style comments.
Changes:
- Check out
microsoft/aspire.devunder an explicitpath: aspire.devin thesafe_outputsjob. - Run the git remote/token configuration step from
working-directory: aspire.dev.
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Update the generated safe_outputs job so cross-repo PR creation checks out microsoft/aspire.dev in a subdirectory path and configures git inside that checkout. This matches the runtime requirement from run 24118533263, where create_pull_request fell back to a comment because the target repository was not found in the workspace. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Description
Follow-up to the
pr-docs-checkworkflow after thev0.67.2regeneration work.Root cause
Run https://github.com/microsoft/aspire/actions/runs/24118533263 completed the agent phase and produced the docs changes, but
create_pull_requeststill fell back to an issue-style comment on #15906 (comment).The safe-outputs handler error was:
So this was no longer a token/permission problem. The generated
safe_outputsjob was checking outmicrosoft/aspire.devat the workspace root, but the cross-repo PR creation handler expects that target repo checkout to live under an explicitpath.What this changes
safe_outputsjob to check outmicrosoft/aspire.devwithpath: aspire.dev.working-directory: aspire.dev.Why this should work
The agent already had access to the docs repo and produced a valid
create_pull_requestoutput. This change aligns the follow-up safe-output job with the handler's workspace discovery requirement so it can actually open the draft PR instead of falling back to the explanatory comment.