Skip to content

feat(ai): add agent skill rendering core#287

Merged
dmcilvaney merged 6 commits into
microsoft:mainfrom
dmcilvaney:damcilva/agent-skill-core
Jul 22, 2026
Merged

feat(ai): add agent skill rendering core#287
dmcilvaney merged 6 commits into
microsoft:mainfrom
dmcilvaney:damcilva/agent-skill-core

Conversation

@dmcilvaney

Copy link
Copy Markdown
Contributor

First part in the changes that allow azldev to emit its own agent instructions. End result: microsoft/azurelinux#17949

Copilot AI review requested due to automatic review settings July 14, 2026 20:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces the internal/app/azldev/agentskill “rendering core” that embeds and renders agent skill / instruction markdown from Go templates, so azldev can emit version-matched agent guidance via on-disk files, CLI output, and MCP responses.

Changes:

  • Added the agentskill package with registries for skills/instructions, embedding + rendering logic, and a default on-disk layout.
  • Added shared wrapper templates and an initial azldev skill body template.
  • Added unit tests and authoring/maintenance instructions for keeping skills accurate and drift-resistant.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
internal/app/azldev/agentskill/doc.go Package-level documentation describing the registries, rendering modes, and maintenance model.
internal/app/azldev/agentskill/agentskill.go Core registries + template rendering APIs (SkillDocument, Files, layout helpers).
internal/app/azldev/agentskill/agentskill_test.go Tests validating front-matter invariants and wrapper/full rendering behavior.
internal/app/azldev/agentskill/content/skill-wrapper.md.tmpl Generic “redirect wrapper” skill template pointing to the MCP tool / CLI.
internal/app/azldev/agentskill/content/instruction-wrapper.md.tmpl Generic instruction wrapper template with applyTo and skill pointers.
internal/app/azldev/agentskill/content/azldev.md.tmpl Initial full-body azldev skill template with command list substitution.
.github/instructions/agent-skills.instructions.md New contributor guidance for adding/editing skills and wrappers and preventing drift.
.github/copilot-instructions.md Notes that agent skills may need updates after CLI/config/workflow behavior changes.

Comment thread internal/app/azldev/agentskill/content/skill-wrapper.md.tmpl
Comment thread internal/app/azldev/agentskill/content/azldev.md.tmpl
Comment thread internal/app/azldev/agentskill/content/instruction-wrapper.md.tmpl
Comment thread internal/app/azldev/agentskill/agentskill.go
Comment thread internal/app/azldev/agentskill/agentskill.go
Comment thread internal/app/azldev/agentskill/agentskill_test.go
Comment thread .github/instructions/agent-skills.instructions.md Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 23:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comment thread internal/app/azldev/agentskill/agentskill.go
Comment thread .github/instructions/agent-skills.instructions.md
Comment thread .github/instructions/agent-skills.instructions.md
Copilot AI review requested due to automatic review settings July 16, 2026 16:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comment thread internal/app/azldev/agentskill/agentskill_internal_test.go
Copilot AI review requested due to automatic review settings July 16, 2026 23:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comment thread internal/app/azldev/agentskill/agentskill_internal_test.go

@Tonisal-byte Tonisal-byte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcilvaney
dmcilvaney merged commit 8c4f762 into microsoft:main Jul 22, 2026
19 checks passed
@dmcilvaney
dmcilvaney deleted the damcilva/agent-skill-core branch July 22, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants