chore(mage): pin python requirements, update docs+mage#297
Open
dmcilvaney wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s Python lint/typecheck toolchain to use pinned pip requirements, and adjusts Mage targets/docs/CI/devcontainer so Python checks are treated as optional unless explicitly requested.
Changes:
- Add
requirements-lint.txtand switch CI/devcontainer/docs to install Python lint tools from it. - Introduce a
mage check defaulttarget and updatemage allto run default (Go) checks instead ofcheck all. - Update developer documentation and devcontainer build context/copy paths to match the new installation flow.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| requirements-lint.txt | Adds pinned versions for Python lint/typecheck tools (ruff, pyright). |
| magefiles/magefile.go | Updates mage all to run default checks instead of all checks. |
| magefiles/magecheckfix/checkfix.go | Adds default check target and refactors all vs default check composition. |
| internal/app/azldev/core/sources/render_process.py | Updates file header copyright line. |
| docs/developer/reference/coding-standards.md | Documents installing pinned Python tools from requirements-lint.txt. |
| docs/developer/reference/build.md | Clarifies tooling expectations and distinguishes check default vs check all. |
| docs/developer/how-to/get-started.md | Updates Python setup to use a venv and install pinned lint requirements. |
| docs/developer/how-to/dev-workflow.md | Updates recommended commands to reflect new mage all / Python-check behavior. |
| .gitignore | Ignores common Python virtual environment directories. |
| .github/workflows/python.yml | Installs Python lint tools from requirements-lint.txt in CI. |
| .github/dependabot.yml | Adds Dependabot updates for pip-based Python lint tooling. |
| .github/copilot-instructions.md | Updates agent guidance for when to run mage check all vs mage all. |
| .devcontainer/README.md | Points devcontainer Python tool installation to pinned requirements. |
| .devcontainer/Dockerfile.AZL-3.0 | Installs pinned Python lint tools and fixes COPY paths for repo-root build context. |
| .devcontainer/devcontainer.json | Switches build context to repo root to support copying root files into the image. |
dmcilvaney
marked this pull request as ready for review
July 24, 2026 00:38
dmcilvaney
commented
Jul 24, 2026
| # Install required packages | ||
| RUN tdnf -y update && \ | ||
| tdnf -y install ca-certificates dnf dnf-utils which gh git golang gawk tar shadow-utils sudo tree bash-completion moby-engine moby-cli build-essential python3-pip nodejs && \ | ||
| tdnf -y install ca-certificates dnf dnf-utils which gh git golang gawk tar shadow-utils sudo tree bash-completion moby-engine moby-cli build-essential python3-pip && \ |
Contributor
Author
There was a problem hiding this comment.
note: pyright brings its own copy of nodejs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.