docs: Add missing uki-addons output artifacts item type

docs/imagecustomizer/api/configuration/injectArtifactMetadata.md

@@ -79,6 +79,15 @@ Optional.
 The type of artifact being injected. This field helps users identify which signing
 process to apply to each artifact.
 
-For supported values, see [`output.artifacts.items`](./outputArtifacts.md#items-string).
+Supported values:
+
+- `ukis` – UKI PE images.
+- `uki-addons` – UKI addon files (`vmlinuz-<version>.addon.efi`). These are
+  automatically generated when `ukis` is specified in
+  [`output.artifacts.items`](./outputArtifacts.md#items-string) and the base image
+  contains UKI addon files.
+- `shim` – Bootloader shim executable.
+- `bootloader` – Bootloader executable (grub or systemd-boot).
+- `verity-hash` – Verity hash files.
 
 Added in v1.1.

run-tests.sh

@@ -0,0 +1 @@
+/home/vinceaperri/src/github.com/vinceaperri/azure-linux-image-tools-test-runner/run-tests.sh

toolkit/tools/imagecustomizerapi/artifacts.go

@@ -16,7 +16,7 @@ func (a *Artifacts) IsValid() error {
 	}
 
 	for _, item := range a.Items {
-		if err := item.IsValid(); err != nil {
+		if err := item.IsValidOutputItem(); err != nil {
 			return err
 		}
 	}

toolkit/tools/imagecustomizerapi/outputartifactsitemtype.go

@@ -25,3 +25,17 @@ func (i OutputArtifactsItemType) IsValid() error {
 		return fmt.Errorf("invalid item value (%v)", i)
 	}
 }
+
+// IsValidOutputItem validates that the item is a user-selectable output artifact type.
+// The uki-addons type is excluded because addon files are automatically included
+// when ukis is specified. The uki-addons type is only valid as an inject-files
+// metadata type.
+func (i OutputArtifactsItemType) IsValidOutputItem() error {
+	switch i {
+	case OutputArtifactsItemUkis, OutputArtifactsItemShim, OutputArtifactsItemBootloader, OutputArtifactsItemVerityHash,
+		OutputArtifactsItemDefault:
+		return nil
+	default:
+		return fmt.Errorf("invalid item value (%v)", i)
+	}
+}

toolkit/tools/imagecustomizerapi/outputartifactsitemtype_test.go

@@ -9,9 +9,10 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestItemIsValid_ValidItems(t *testing.T) {
+func TestOutputArtifactsItemTypeIsValid_ValidItems_Pass(t *testing.T) {
 	validItems := []OutputArtifactsItemType{
 		OutputArtifactsItemUkis,
+		OutputArtifactsItemUkiAddons,
 		OutputArtifactsItemShim,
 		OutputArtifactsItemBootloader,
 		OutputArtifactsItemVerityHash,
@@ -24,9 +25,37 @@ func TestItemIsValid_ValidItems(t *testing.T) {
 	}
 }
 
-func TestItemIsValid_InvalidItem(t *testing.T) {
+func TestOutputArtifactsItemTypeIsValid_InvalidItem_Fail(t *testing.T) {
 	invalidItem := OutputArtifactsItemType("invalidItem")
 	err := invalidItem.IsValid()
 	assert.Error(t, err)
 	assert.ErrorContains(t, err, "invalid item value")
 }
+
+func TestOutputArtifactsItemTypeIsValidOutputItem_ValidItems_Pass(t *testing.T) {
+	validItems := []OutputArtifactsItemType{
+		OutputArtifactsItemUkis,
+		OutputArtifactsItemShim,
+		OutputArtifactsItemBootloader,
+		OutputArtifactsItemVerityHash,
+		OutputArtifactsItemDefault,
+	}
+
+	for _, item := range validItems {
+		err := item.IsValidOutputItem()
+		assert.NoError(t, err, "valid output item should not return an error: %s", item)
+	}
+}
+
+func TestOutputArtifactsItemTypeIsValidOutputItem_UkiAddons_Fail(t *testing.T) {
+	err := OutputArtifactsItemUkiAddons.IsValidOutputItem()
+	assert.Error(t, err)
+	assert.ErrorContains(t, err, "uki-addons are automatically included with ukis")
+}
+
+func TestOutputArtifactsItemTypeIsValidOutputItem_InvalidItem_Fail(t *testing.T) {
+	invalidItem := OutputArtifactsItemType("invalidItem")
+	err := invalidItem.IsValidOutputItem()
+	assert.Error(t, err)
+	assert.ErrorContains(t, err, "invalid item value")
+}