Skip to content

Fix network isolation: remove package installation steps from 1ES runner workflows #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −138
Draft

Fix network isolation: remove package installation steps from 1ES runner workflows #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9819cf4
Initial plan
Copilot Mar 30, 2026
db16704
Fix network isolation: remove package installation steps from 1ES run…
Copilot Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions .github/workflows/tests-functional.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ on:
required: true
type: string

env:
EXPECTED_GO_VERSION: "1.25.0"

jobs:
tests-functional:
name: Functional test suite - ${{ inputs.testDistro }} on ${{ inputs.hostDistro }} ${{ inputs.hostArch }}
Expand All @@ -33,55 +30,12 @@ jobs:
id-token: write
environment: public
steps:
- name: setup go 1.x
uses: actions/setup-go@v6
with:
go-version: "~${{ env.EXPECTED_GO_VERSION }}"

- name: Checkout
uses: actions/checkout@v6
with:
path: repo
persist-credentials: false

- name: Install prerequisites (AZL3)
if: inputs.hostDistro == 'azl3'
run: |
set -eux

# Install Image Customizer prerequisities.
PACKAGES="qemu-img rpm coreutils util-linux systemd openssl \
sed createrepo_c squashfs-tools cdrkit e2fsprogs dosfstools \
xfsprogs btrfs-progs zstd veritysetup grub2 binutils lsof \
git azure-cli systemd-ukify"

# grub2-pc is only available on x86.
if [[ "$HOST_ARCH" == "amd64" ]]; then
PACKAGES+=" grub2-pc"
fi

sudo ./repo/.github/workflows/scripts/retry.sh 5 5 \
tdnf install -y $PACKAGES

sudo tdnf list installed
env:
HOST_ARCH: ${{ inputs.hostArch }}

- name: Install prerequisites (Ubuntu 24.04)
if: inputs.hostDistro == 'ubuntu2404'
run: |
set -eux

# Install Image Customizer prerequisities.
sudo apt list --installed
sudo apt update -y

sudo apt -y install qemu-utils rpm coreutils util-linux mount fdisk udev openssl \
sed createrepo-c squashfs-tools genisoimage e2fsprogs dosfstools \
xfsprogs btrfs-progs zstd cryptsetup-bin grub2-common binutils lsof systemd-ukify

curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash

- name: Azure Login
uses: azure/login@532459ea530d8321f2fb9bb10d1e0bcf23869a43 # v3.0.0
with:
Expand Down
46 changes: 0 additions & 46 deletions .github/workflows/tests-vmtests-osmodifier.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ on:
required: true
type: string

env:
EXPECTED_GO_VERSION: "1.25.0"

jobs:
tests-osmodifier:
name: Tests osmodifier VMTests suite - ${{ inputs.hostDistro }} ${{ inputs.hostArch }}
Expand All @@ -30,55 +27,12 @@ jobs:
id-token: write
environment: public
steps:
- name: Setup Go toolchain
uses: actions/setup-go@v6
with:
go-version: "~${{ env.EXPECTED_GO_VERSION }}"

- name: Checkout
uses: actions/checkout@v6
with:
path: repo
persist-credentials: false

- name: Install prerequisites (AZL3)
if: inputs.hostDistro == 'azl3'
run: |
set -eux

sudo ./repo/.github/workflows/scripts/retry.sh 5 5 \
tdnf install -y \
libvirt libvirt-daemon libvirt-daemon-config-network \
libvirt-daemon-kvm libvirt-devel qemu-kvm qemu-img python3-libvirt \
python3-devel edk2-ovmf \
azure-cli

sudo tdnf list installed

sudo systemctl restart libvirtd
sudo systemctl status libvirtd

- name: Install prerequisites (Ubuntu 24.04)
if: inputs.hostDistro == 'ubuntu2404'
run: |
set -eux

sudo apt update -y
sudo apt -y install python3-venv python3-pip python3-dev \
libvirt-dev libvirt-daemon libvirt-daemon-system libvirt-clients \
qemu-kvm virt-manager

# Install arm64 specific
if [[ "$HOST_ARCH" == "arm64" ]]; then
sudo apt -y install qemu-system-arm qemu-efi-aarch64 ovmf seabios
fi

sudo apt list --installed

curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash
env:
HOST_ARCH: ${{ inputs.hostArch }}

- name: Azure Login
uses: azure/login@532459ea530d8321f2fb9bb10d1e0bcf23869a43 # v3.0.0
with:
Expand Down
46 changes: 0 additions & 46 deletions .github/workflows/tests-vmtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ on:
required: true
type: string

env:
EXPECTED_GO_VERSION: "1.25.0"

jobs:
tests-vmtests:
name: Tests imagecustomizer VMTests suite - ${{ inputs.hostDistro }} ${{ inputs.hostArch }}
Expand All @@ -30,55 +27,12 @@ jobs:
id-token: write
environment: public
steps:
- name: setup go 1.x
uses: actions/setup-go@v6
with:
go-version: "~${{ env.EXPECTED_GO_VERSION }}"

- name: Checkout
uses: actions/checkout@v6
with:
path: repo
persist-credentials: false

- name: Install prerequisites (AZL3)
if: inputs.hostDistro == 'azl3'
run: |
set -eux

sudo ./repo/.github/workflows/scripts/retry.sh 5 5 \
tdnf install -y \
libvirt libvirt-daemon libvirt-daemon-config-network \
libvirt-daemon-kvm libvirt-devel qemu-kvm qemu-img python3-libvirt \
python3-devel edk2-ovmf \
azure-cli

sudo tdnf list installed

sudo systemctl restart libvirtd
sudo systemctl status libvirtd

- name: Install prerequisites (Ubuntu 24.04)
if: inputs.hostDistro == 'ubuntu2404'
run: |
set -eux

sudo apt update -y
sudo apt -y install python3-venv python3-pip python3-dev \
libvirt-dev libvirt-daemon libvirt-daemon-system libvirt-clients \
qemu-kvm virt-manager

# Install arm64 specific
if [[ "$HOST_ARCH" == "arm64" ]]; then
sudo apt -y install qemu-system-arm qemu-efi-aarch64 ovmf seabios
fi

sudo apt list --installed

curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash
env:
HOST_ARCH: ${{ inputs.hostArch }}

- name: Azure Login
uses: azure/login@532459ea530d8321f2fb9bb10d1e0bcf23869a43 # v3.0.0
with:
Expand Down
Loading