ci: run PR checks across configured deployments#18039
Draft
PawelWMS wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Expands Control Tower PR validation across DEV, STAGING, and PROD deployments.
Changes:
- Generates parallel, deployment-specific validation jobs.
- Adds unique output paths and artifact names.
- Switches to OneBranch Official governance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ado/pr-check-ct.yml |
Configures deployment endpoints and service connections. |
.github/workflows/ado/templates/pr-check-ct-stages.yml |
Generates and runs parallel deployment jobs. |
PawelWMS
marked this pull request as draft
July 16, 2026 21:07
jslobodzian
approved these changes
Jul 16, 2026
PawelWMS
commented
Jul 16, 2026
jslobodzian
reviewed
Jul 16, 2026
PawelWMS
commented
Jul 16, 2026
PawelWMS
force-pushed
the
pseudotrurl/pr-check-ct-multi-deployment
branch
from
July 16, 2026 21:55
d1ab1f7 to
ef25021
Compare
PawelWMS
force-pushed
the
pseudotrurl/pr-check-ct-multi-deployment
branch
from
July 16, 2026 22:20
ef25021 to
c37f055
Compare
PawelWMS
force-pushed
the
pseudotrurl/pr-check-ct-multi-deployment
branch
from
July 16, 2026 23:20
c37f055 to
a2dfab5
Compare
PawelWMS
marked this pull request as ready for review
July 17, 2026 00:08
PawelWMS
marked this pull request as draft
July 17, 2026 00:14
Generate one parallel Control Tower job for each configured deployment so one reviewer-gated run exercises DEV, STAGING, and PROD. Keep each deployment's audience, endpoint, service connection, and error policy together. Run prcheck for every deployment, make STAGING non-blocking, and limit scratch package builds to DEV. Use renewable Azure Pipelines WIF credentials during long-running API polls, with Azure CLI fallback for local execution. Reuse the DEV-specific audience and endpoint in the post-merge package wrapper. Use OneBranch Official because the PR pipeline accesses a production-scoped identity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PawelWMS
force-pushed
the
pseudotrurl/pr-check-ct-multi-deployment
branch
from
July 17, 2026 23:38
a2dfab5 to
95a4a94
Compare
Comment on lines
+52
to
+59
| def test_uses_pipeline_service_connection( | ||
| self, | ||
| lifecycle_mocks: tuple[Mock, Mock, Mock, Mock], | ||
| ) -> None: | ||
| """Use the identity authenticated by the enclosing AzureCLI task.""" | ||
| _submit() | ||
|
|
||
| package_build.ct.make_credential.assert_called_once_with() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Allow one reviewer-gated pipeline run to exercise Control Tower calls across multiple deployments and surface deployment-specific results.
Risk
Each deployment repeats change detection and dependency setup, increasing agent usage. The production-scoped execution risk is explicitly accepted and documented in Azure Linux internal policies; reviewer gating remains a procedural control rather than an authorization boundary.
Verification