test(images): add image-read-only-checks LISA qemu test suite#18042
Draft
liunan-ms wants to merge 1 commit into
Draft
test(images): add image-read-only-checks LISA qemu test suite#18042liunan-ms wants to merge 1 commit into
liunan-ms wants to merge 1 commit into
Conversation
| type = "lisa" | ||
| description = "Lisa read-only checks(no reboot, no fresh VM) on QEMU VM" | ||
|
|
||
| [test-suites.image-read-only-checks.lisa] |
Comment on lines
+193
to
+195
| # aborts the wheel build. libvirt-python must instead match the host libvirt | ||
| # version, so install it (plus pycdlib) into the LISA venv out-of-band, e.g.: | ||
| # <venv>/bin/pip install "libvirt-python==<host-libvirt-version>" "pycdlib~=1.12" |
Comment on lines
+205
to
+207
| # 'libvirt' is intentionally omitted here — its pin (~= 9.3.0) breaks against a | ||
| # modern host libvirt. Install a host-matching libvirt-python + pycdlib into the | ||
| # venv manually instead. See the note above this suite for details. |
tobiasb-ms
requested changes
Jul 17, 2026
tobiasb-ms
left a comment
tobiasb-ms
left a comment
Contributor
There was a problem hiding this comment.
issue(blocking): The commit and PR name don't follow conventional commits. images is not one of the approved things. I suggest test(images): ....
| description = "Lisa read-only checks(no reboot, no fresh VM) on QEMU VM" | ||
|
|
||
| [test-suites.image-read-only-checks.lisa] | ||
| # 'libvirt' is intentionally omitted here — its pin (~= 9.3.0) breaks against a |
Contributor
There was a problem hiding this comment.
issue(blocking): You document this thing about libvirt not being in pip-extras here and above. Pick one please.
liunan-ms
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
image-read-only-checksLISA qemu test suite forvm-baseimage validation and documents thepip-extrashandling for libvirt.Details
image-read-only-checkstest suite (typelisa) that boots a QEMU VM from the built image artifact and runs a set of read-only (no reboot, no fresh VM) checks.libvirtpip extra is intentionally omitted frompip-extras: that extra pinslibvirt-python ~= 9.3.0, which fails to build against a modern host libvirt (e.g. 11.x) because its bundledgenerator.pycannot map newer API entries inlibvirt-api.xml. A host-matchinglibvirt-python(pluspycdlib) should be installed into the LISA venv out-of-band instead.Testing
azldev image test vm-base --test-suite image-read-only-checks --image-path <qcow2>-> all 16 test cases PASSED on a local QEMU/libvirt host (libvirt 11.6.0).