Skip to content

Add Windows PID-based kill command --from winuxcmd project #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-rookie-of-C-language wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Windows PID-based kill command --from winuxcmd project #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b753b82
Implements a Windows-specific kill shim using TerminateProcess, regis…
a-rookie-of-C-language Jun 4, 2026
bcf4f66
Improve Windows kill compatibility
a-rookie-of-C-language Jun 4, 2026
cacb173
Move Windows kill shim into deps crate
a-rookie-of-C-language Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ uptime = { package = "uu_uptime", path = "deps/coreutils/src/uu/uptime" }
findutils = { package = "findutils", path = "deps/findutils" }
grep = { package = "uu_grep", path = "deps/grep" }
ntfind = { package = "find", path = "deps/ntfind" }
ntkill = { path = "deps/ntkill" }

# For registry access in main.rs
[dependencies.windows-sys]
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Legend: ✅ ships and works · ⚠️ ships but conflicts with a built-in ·
| `expand` | 🛑 | 🛑 | Conflicts with the built-in DOS command |
| `find` | ✅ | ✅ | Integrated port of the original DOS command |
| `hostname` | ✅ | ✅ | Superset of the Windows built-in |
| `kill` | 🛑 | 🛑 | Unavailable due to lack of signals on Windows; Implementing a form of SIGTERM/SIGKILL may be possible in the future however |
| `kill` | ✅ | ⚠️ | Terminates processes by PID. `0` probes access, while `TERM` and `KILL` both map to Windows process termination. Unix process groups aren't supported. |
| `ls` | ✅ | ⚠️ | |
| `mkdir` | ⚠️ | ⚠️ | |
| `more` | 🛑 | 🛑 | Conflicts with the built-in DOS command (consider `edit` as an alternative) |
Expand All @@ -72,7 +72,7 @@ Legend: ✅ ships and works · ⚠️ ships but conflicts with a built-in ·
| `sleep` | ✅ | ⚠️ | |
| `sort` | ✅ | ✅ | Integrated port of the original DOS command |
| `tee` | ✅ | ⚠️ | |
| `timeout` | 🛑 | 🛑 | Relies on `kill`'s functionality |
| `timeout` | 🛑 | 🛑 | Requires broader timeout and process-management support |
| `uptime` | ✅ | ⚠️ | |
| `whoami` | 🛑 | 🛑 | Conflicts with the built-in Windows command |

Expand Down
4 changes: 4 additions & 0 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ fn generate_uutils_map() {
entries.push(("sort".into(), "(sort_uumain, sort_uu_app)".into()));
}

if !coreutils.iter().any(|(util, _)| util == "kill") {
entries.push(("kill".into(), "(kill_uumain, kill_uu_app)".into()));
}

entries.sort();

let mut phf_map = phf_codegen::OrderedMap::new();
Expand Down
19 changes: 19 additions & 0 deletions deps/ntkill/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
[package]
name = "ntkill"
edition = "2024"
license = "MIT"
repository = "https://github.com/microsoft/coreutils"
rust-version = "1.88.0"
version = "0.0.0"
publish = false

[dependencies]
clap = { version = "4.5", features = ["wrap_help", "cargo", "color"] }
uucore = { path = "../coreutils/src/uucore" }

[dependencies.windows-sys]
version = "*"
features = [
"Win32_Foundation",
"Win32_System_Threading",
]
Loading